Page MenuHomeFreeBSD

libsa: Update comments about SMBIOS specification
ClosedPublic

Authored by stevek on Apr 18 2023, 1:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 12 2024, 10:49 PM
Unknown Object (File)
Jan 14 2024, 6:58 AM
Unknown Object (File)
Dec 20 2023, 7:15 AM
Unknown Object (File)
Nov 16 2023, 12:29 AM
Unknown Object (File)
Oct 14 2023, 11:28 PM
Unknown Object (File)
Sep 19 2023, 12:39 AM
Unknown Object (File)
Jun 20 2023, 4:36 PM
Unknown Object (File)
May 25 2023, 12:39 PM
Subscribers

Details

Summary

Include details from the SMBIOS 3 specification and some additional
details for SMBIOS 2.1.

Obtained from: Juniper Networks, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I generally like this a lot. Thanks for doing it.

stand/libsa/smbios.c
90

Needs a closing quote.

Also, this is starting to get a little lengthy for a quote. Do the standards say you need permission to quote? If not, I think it's short enough to be fine. If it does, however, we may look to trim a bit.

This revision is now accepted and ready to land.Apr 18 2023, 2:57 AM
In D39635#902089, @imp wrote:

Also, this is starting to get a little lengthy for a quote. Do the standards say you need permission to quote? If not, I think it's short enough to be fine. If it does, however, we may look to trim a bit.

According to the specification:
"Members and non-members may reproduce DMTF specifications and documents, provided that correct attribution is given."

Added closing quote per review comments

This revision now requires review to proceed.Apr 18 2023, 3:08 AM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 18 2023, 3:22 AM
This revision was automatically updated to reflect the committed changes.