bridge: Use %D identifier to format MAC address
ClosedPublic
Actions

Authored by zlei on Apr 13 2023, 3:13 AM.

Details

Reviewers

Commits

rG9af6f4268ac3: bridge: Use the %D identifier to format MAC address

Summary

It is shorter and more readable.

No functional change intended.

Fixes: 2d3614fb132b bridge: Log MAC address port flapping
MFC after: 8 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei created this revision.Apr 13 2023, 3:13 AM

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptApr 13 2023, 3:13 AM

zlei requested review of this revision.Apr 13 2023, 3:13 AM

I did not know about %D. It's good to learn things :)

This revision is now accepted and ready to land.Apr 13 2023, 6:58 AM

In D39542#900188, @kp wrote:

I did not know about %D. It's good to learn things :)

I found that while hacking the VLAN PCP bugs ;)

See sys/net/if_ethersubr.c:

/*
 * Perform common duties while attaching to interface list
 */
void
ether_ifattach(struct ifnet *ifp, const u_int8_t *lla)
{
...
        if (i != ifp->if_addrlen)
                if_printf(ifp, "Ethernet address: %6D\n", lla, ":");
...
}

Closed by commit rG9af6f4268ac3: bridge: Use the %D identifier to format MAC address (authored by zlei). · Explain WhyApr 14 2023, 10:10 AM

This revision was automatically updated to reflect the committed changes.

zlei added a commit: rG9af6f4268ac3: bridge: Use the %D identifier to format MAC address.

zlei mentioned this in rGde53ebb0f20e: bridge: Log MAC address port flapping.Apr 21 2023, 10:11 AM

zlei mentioned this in rG303d9a593bdd: bridge: Log MAC address port flapping.Apr 21 2023, 10:18 AM

Revision Contents
Changeset List

Path

Size

sys/

net/

if_bridge.c

5 lines

Diff 120303

View Options

bridge: Use %D identifier to format MAC addressClosedPublicActions