Page MenuHomeFreeBSD
Differential D39454

netinet tests: test carp source MAC address
ClosedPublic
Actions

Authored by kp on Apr 6 2023, 4:12 PM.
Tags
None
Referenced Files
F150704196: D39454.id.diff
Fri, Apr 3, 12:05 PM
Unknown Object (File)
Thu, Apr 2, 2:16 PM
Unknown Object (File)
Sun, Mar 29, 7:13 AM
Unknown Object (File)
Sun, Mar 29, 5:50 AM
Unknown Object (File)
Fri, Mar 27, 10:35 AM
Unknown Object (File)
Fri, Mar 27, 4:17 AM
Unknown Object (File)
Thu, Mar 26, 8:25 PM
Unknown Object (File)
Thu, Mar 26, 1:53 PM
View All Files
Subscribers
asomers
glebius
imp

Details

Reviewers
markj
melifaro
Group Reviewers
network
pfsense
Commits
rG5e2e3615d91f: netinet tests: test carp source MAC address
Summary

Ensure that (multicast) CARP packets are sent with the expected source
MAC address.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Errors
SeverityLocationCodeMessage
Errortests/sys/netinet/carp.py:7E302PEP8 E302
Errortests/sys/netinet/carp.py:14E302PEP8 E302
Errortests/sys/netinet/carp.py:15E225PEP8 E225
Errortests/sys/netinet/carp.py:17E201PEP8 E201
Errortests/sys/netinet/carp.py:17E201PEP8 E201
Errortests/sys/netinet/carp.py:17E202PEP8 E202
Errortests/sys/netinet/carp.py:17E202PEP8 E202
Errortests/sys/netinet/carp.py:18E201PEP8 E201
Errortests/sys/netinet/carp.py:18E202PEP8 E202
Errortests/sys/netinet/carp.py:42E225PEP8 E225
Errortests/sys/netinet/carp.py:44E501PEP8 E501
Unit
No Test Coverage
Build Status
Buildable 50799
Build 47690: arc lint + arc unit

Event Timeline

kp created this revision.Apr 6 2023, 4:12 PM
Herald added subscribers: glebius, asomers, imp. · View Herald TranscriptApr 6 2023, 4:12 PM
kp requested review of this revision.Apr 6 2023, 4:12 PM
Harbormaster completed remote builds in B50799: Diff 119951.Apr 6 2023, 4:12 PM
kp mentioned this in D39445: tests: convert forwarding tests to python.Apr 6 2023, 4:17 PM
melifaro accepted this revision.Apr 7 2023, 10:11 AM

LGTM!

The only thing - it's probably worth running black, flake8 and reorder-python-imports on the test file to ensure consistent formatting.

This revision is now accepted and ready to land.Apr 7 2023, 10:11 AM
This revision was landed with ongoing or failed builds.Apr 7 2023, 3:58 PM
Closed by commit rG5e2e3615d91f: netinet tests: test carp source MAC address (authored by kp). · Explain Why
This revision was automatically updated to reflect the committed changes.
kp added a commit: rG5e2e3615d91f: netinet tests: test carp source MAC address.

Revision Contents
Changeset List

PathSize
tests/
sys/
netinet/
2 lines
52 lines

Diff 119951

View Options

tests/sys/netinet/Makefile

Loading...
View Options

tests/sys/netinet/carp.py

Loading...