Page MenuHomeFreeBSD

rc.d/zfsbe: Simplify
ClosedPublic

Authored by imp on Apr 4 2023, 6:13 PM.
Tags
None
Referenced Files
F165016459: D39413.id121347.diff
Wed, Aug 5, 8:29 AM
F164956878: D39413.id119844.diff
Wed, Aug 5, 2:59 AM
Unknown Object (File)
Tue, Aug 4, 7:17 AM
Unknown Object (File)
Jul 2 2026, 6:27 AM
Unknown Object (File)
Jun 29 2026, 1:53 PM
Unknown Object (File)
Jun 28 2026, 1:50 PM
Unknown Object (File)
Jun 27 2026, 6:45 AM
Unknown Object (File)
Jun 24 2026, 5:13 PM
Subscribers

Details

Summary

So $(foo) is a shorter version of "foo".

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 50758
Build 47649: arc lint + arc unit

Event Timeline

imp requested review of this revision.Apr 4 2023, 6:13 PM
imp created this revision.
jlduran added inline comments.
libexec/rc/rc.d/zfsbe
60

Should we still keep the double quotes? (To to prevent globbing and word splitting as shellsheck would say, although unlikely).

libexec/rc/rc.d/zfsbe
60

Are they needed here? Word expansion doesn't happen here after the substitution, so _bootonce will have whatever is the value of zfs-bootonce, even if there's spaces.

libexec/rc/rc.d/zfsbe
60

Are they needed here?

Unlikely.

This revision was not accepted when it landed; it landed in state Needs Review.May 1 2023, 9:04 PM
Closed by commit rG0c4183f02efc: rc.d/zfsbe: Simplify (authored by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.