Page MenuHomeFreeBSD
Differential D39204

routing: add public rt_is_exportable() version to check if route can be exported to userland when jailed.
ClosedPublic
Actions

Authored by melifaro on Mar 22 2023, 11:50 AM.
Tags
None
Referenced Files
F168181214: D39204.id119472.diff
Wed, Aug 26, 6:13 PM
Unknown Object (File)
Wed, Aug 26, 5:35 AM
Unknown Object (File)
Wed, Aug 26, 4:18 AM
Unknown Object (File)
Wed, Aug 26, 12:16 AM
Unknown Object (File)
Tue, Aug 25, 8:08 PM
Unknown Object (File)
Mon, Aug 24, 9:52 AM
Unknown Object (File)
Sat, Aug 22, 10:34 AM
Unknown Object (File)
Sat, Aug 22, 8:16 AM
View All Files
Subscribers
ae
glebius
imp
zlei

Details

Reviewers
None
Group Reviewers
network
Commits
rG2ccf6388ba60: routing: add public rt_is_exportable() version to check if
rG2cda6a2fb0d9: routing: add public rt_is_exportable() version to check if

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 50518
Build 47409: arc lint + arc unit

Event Timeline

melifaro created this revision.Mar 22 2023, 11:50 AM
Herald added subscribers: glebius, ae, imp. · View Herald TranscriptMar 22 2023, 11:50 AM
melifaro requested review of this revision.Mar 22 2023, 11:50 AM
Harbormaster completed remote builds in B50517: Diff 119241.Mar 22 2023, 11:50 AM
melifaro added a reviewer: network.Mar 22 2023, 11:51 AM
melifaro updated this revision to Diff 119242.Mar 22 2023, 11:52 AM

.

Harbormaster completed remote builds in B50518: Diff 119242.Mar 22 2023, 11:52 AM
zlei added a subscriber: zlei.Mar 22 2023, 1:40 PM
zlei added inline comments.
sys/net/route/route_rtentry.c
202
  1. If the process is in legacy jail, only allow export host routes for the addresses assigned to the jail.
  2. Otherwise, allow export.

Am I right ?

melifaro added inline comments.Mar 22 2023, 3:15 PM
sys/net/route/route_rtentry.c
202

Yes (and this is actually should be written in the description)

This revision was not accepted when it landed; it landed in state Needs Review.Mar 26 2023, 8:38 AM
Closed by commit rG2cda6a2fb0d9: routing: add public rt_is_exportable() version to check if (authored by melifaro). · Explain Why
This revision was automatically updated to reflect the committed changes.
melifaro added a commit: rG2cda6a2fb0d9: routing: add public rt_is_exportable() version to check if.
melifaro added a commit: rG2ccf6388ba60: routing: add public rt_is_exportable() version to check if.Apr 9 2023, 1:53 PM

Revision Contents
Changeset List

PathSize
sys/
net/
route/
2 lines
19 lines
29 lines

Diff 119242

View Options

sys/net/route/route_ctl.h

Loading...
View Options

sys/net/route/route_rtentry.c

Loading...
View Options

sys/net/rtsock.c

Loading...