ping: Avoid magic numbers
ClosedPublic
Actions

Authored by jlduran on Mar 16 2023, 4:35 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 26, 4:10 PM

	Unknown Object (File)
	Sun, Dec 21, 1:06 PM

	Unknown Object (File)
	Thu, Dec 11, 6:13 PM

	Unknown Object (File)
	Thu, Dec 11, 7:37 AM

	Unknown Object (File)
	Thu, Dec 11, 7:37 AM

	Unknown Object (File)
	Thu, Dec 11, 7:37 AM

	Unknown Object (File)
	Nov 26 2025, 4:53 AM

	Unknown Object (File)
	Nov 17 2025, 10:01 AM

View All Files

Subscribers

imp

Contributor Reviews (src)

Details

Reviewers

markj
asomers

Group Reviewers

network

Commits

rG3c7ef29e8998: ping: Avoid magic numbers
rG491263d7a640: ping: Avoid magic numbers

Summary

The sizeof(struct ip) is 20.
The sizeof(struct in_addr) is 4.
No functional change intended.

Test Plan

kyua test -k /usr/tests/Kyuafile sbin/ping/ping_test
kyua test -k /usr/tests/Kyuafile sbin/ping/test_ping.py

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jlduran created this revision.Mar 16 2023, 4:35 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 16 2023, 4:35 PM

jlduran requested review of this revision.Mar 16 2023, 4:35 PM

jlduran added a child revision: D38469: ping: Print the IP options of the original packet.

asomers accepted this revision.Mar 16 2023, 5:02 PM

This revision is now accepted and ready to land.Mar 16 2023, 5:02 PM

jlduran mentioned this in D38469: ping: Print the IP options of the original packet.Mar 16 2023, 6:11 PM

Closed by commit rG491263d7a640: ping: Avoid magic numbers (authored by jlduran, committed by markj). · Explain WhyMar 17 2023, 1:29 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG491263d7a640: ping: Avoid magic numbers.

markj added a commit: rG3c7ef29e8998: ping: Avoid magic numbers.Mar 24 2023, 4:59 PM

Revision Contents
Changeset List

Path

Size

sbin/

ping/

ping.c

6 lines

Diff 119010

View Options

ping: Avoid magic numbersClosedPublicActions