Paths

Table of Contentst

Fix per-jail zfs.mount_snapshot setting
ClosedPublic
Actions

Authored by allanjude on Feb 18 2023, 2:15 AM.

Details

Reviewers

cperciva
mm

Group Reviewers

Klara

Commits

rGb772fe0d6626: Fix per-jail zfs.mount_snapshot setting
rG426ed0052540: Fix per-jail zfs.mount_snapshot setting
rG8b04c1cbfc1c: Fix per-jail zfs.mount_snapshot setting

Summary

When jail.conf set the nopersist flag during startup, it was
incorrectly destroying the per-jail ZFS settings.

PR: 260160
MFC after: immediately
Sponsored by: Modirum MDPay
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 49881
Build 46773: arc lint + arc unit

Event Timeline

allanjude created this revision.Feb 18 2023, 2:15 AM

Herald added subscribers: delphij, imp. · View Herald TranscriptFeb 18 2023, 2:15 AM

allanjude edited the summary of this revision. (Show Details)Feb 18 2023, 2:16 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 18 2023, 2:16 AM

Harbormaster failed remote builds in B49873: Diff 117522!

imp added inline comments.Feb 18 2023, 11:39 PM

sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c
2500	{ is tabbed in one too far. Other instances in the tree use one fewer tabs from a (brief) survey I just did.
2524–2531	default: ? What else is expected?

Update to address Warner's feedback

allanjude requested review of this revision.Feb 19 2023, 1:03 AM

Harbormaster completed remote builds in B49881: Diff 117555.Feb 19 2023, 1:03 AM

I think if we have only two possible choices, a if .. else if would be easier to follow.

zlei added a subscriber: zlei.Feb 20 2023, 2:01 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 21 2023, 10:43 PM

Closed by commit rG8b04c1cbfc1c: Fix per-jail zfs.mount_snapshot setting (authored by allanjude). · Explain Why

This revision was automatically updated to reflect the committed changes.

allanjude added a commit: rG8b04c1cbfc1c: Fix per-jail zfs.mount_snapshot setting.

allanjude added a commit: rG426ed0052540: Fix per-jail zfs.mount_snapshot setting.Feb 21 2023, 10:47 PM

allanjude added a commit: rGb772fe0d6626: Fix per-jail zfs.mount_snapshot setting.Feb 22 2023, 1:49 PM

Revision Contents
Changeset List

Path

Size

sys/

contrib/

openzfs/

module/

os/

freebsd/

zfs/

zfs_vfsops.c

16 lines

Diff 117555

View Options

sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c

Fix per-jail zfs.mount_snapshot settingClosedPublicActions