Paths

Table of Contentst

libc: popen: slightly simplify cloexec logic
ClosedPublic
Actions

Authored by kevans on Jan 9 2023, 5:14 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Sep 30, 1:17 PM

	Unknown Object (File)
	Mon, Sep 28, 11:19 PM

	Unknown Object (File)
	Sat, Sep 26, 10:51 AM

	Unknown Object (File)
	Thu, Sep 24, 3:03 AM

	Unknown Object (File)
	Tue, Sep 22, 6:12 PM

	Unknown Object (File)
	Tue, Sep 22, 6:11 PM

	Unknown Object (File)
	Tue, Sep 22, 3:52 PM

	Unknown Object (File)
	Sat, Sep 12, 4:36 AM

View All Files

Subscribers

imp

Details

Reviewers

jilles
bapt
pstef

Commits

rGf123c6c425d4: libc: popen: slightly simplify cloexec logic

Summary

No need to check the mode again here; we know that iop wraps the
correct fd.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Jan 9 2023, 5:14 AM

Herald added a subscriber: imp. · View Herald TranscriptJan 9 2023, 5:14 AM

kevans requested review of this revision.Jan 9 2023, 5:14 AM

Harbormaster completed remote builds in B48995: Diff 114860.Jan 9 2023, 5:14 AM

LGTM

This revision is now accepted and ready to land.Jan 21 2023, 9:19 PM

Closed by commit rGf123c6c425d4: libc: popen: slightly simplify cloexec logic (authored by kevans). · Explain WhyFeb 13 2023, 6:34 AM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rGf123c6c425d4: libc: popen: slightly simplify cloexec logic.

Revision Contents
Changeset List

Path

Size

lib/

libc/

gen/

popen.c

2 lines

Diff 117080

View Options

libc: popen: slightly simplify cloexec logicClosedPublicActions