This is first step to move the generic part of HV code into kernel instead of module,
so that it is possible to use hypercall to implement some other paravirtualization code in the kernel.
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 1830 Build 1837: arc lint + arc unit
Event Timeline
Comment Actions
I have a couple of comments, but I would really like Wei to take a look at this.
| sys/dev/hyperv/vmbus/hv_vmbus_drv_freebsd.c | ||
|---|---|---|
| 719 | Does this need to depend on ACPI? Is the description for the HyperV paravirtualized devices coming from ACPI tables? | |
| sys/x86/x86/identcpu.c | ||
| 1291 | I'm not really sure this is right, but I might be missing something. AFAICT if smbios.system.product contains "Virtual Machine" the guest type will be set to VM_GUEST_HV which is wrong because Virtual PC is not the same as HyperV. | |
Comment Actions
Thanks for the updated diff, I see that one of my initial comments has not yet been addressed or replied. Wei, can you also please take a look?
| sys/dev/hyperv/vmbus/hv_connection.c | ||
|---|---|---|
| 254 | Is this really meant to be "Protocal" and not "Protocol"? | |
| sys/dev/hyperv/vmbus/hv_vmbus_drv_freebsd.c | ||
| 719 | I see no fix and no comment clarifying this, please either reply to the comment or leave the code as-is. | |
Comment Actions
sorry didn't realize that I didn't submit my comments.
| sys/dev/hyperv/vmbus/hv_connection.c | ||
|---|---|---|
| 254 | Protocol. | |
| sys/dev/hyperv/vmbus/hv_vmbus_drv_freebsd.c | ||
| 719 | Yes. the paravirtualized bus called VMBUS is attached to ACPI bus. | |
| 719 | this is a dump from my hyperv VM of devinfo -v. (I removed non related information) acpi0
unknown pnpinfo _HID=VMBUS _UID=0 at handle=\_SB_.PCI0.SBRG.VMBS (disabled)
vmbus0 pnpinfo _HID=VMBUS _UID=0 at handle=\_SB_.PCI0.SBRG.VMB8
storvsc0
unknown
unknown
unknown | |
| sys/x86/x86/identcpu.c | ||
| 1291 | good point. I will revert this. | |
Comment Actions
Looks good to me overall.
| sys/x86/x86/identcpu.c | ||
|---|---|---|
| 127 | I really doubt if the compiler would be able to make use of the other 3 bytes in this array :) | |