Page MenuHomeFreeBSD
Differential D38365

asmc: add support for 10 byte light sensor payloads
ClosedPublic
Actions

Authored by adrian on Feb 2 2023, 11:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 31, 4:48 AM
Unknown Object (File)
Sat, Jan 31, 12:25 AM
Unknown Object (File)
Thu, Jan 29, 6:35 AM
Unknown Object (File)
Wed, Jan 28, 7:59 PM
Unknown Object (File)
Wed, Jan 28, 4:14 PM
Unknown Object (File)
Wed, Jan 28, 1:22 PM
Unknown Object (File)
Wed, Jan 28, 7:27 AM
Unknown Object (File)
Tue, Jan 20, 12:20 AM
View All Files
Subscribers
emaste
imp

Details

Reviewers
markj
Commits
rG2e9d05fd6848: asmc: Add support for 10 byte light sensor payloads; MacBookAir6,1
Summary

The later macbook models use a different packet payload for the light sensors:

  • there's only one, done in the camera
  • it's a 4 byte value, not a 2 byte value
  • it's in a 10 byte payload

So, this adds support for that and flips it on for the MacbookAir 6,2.
It also adds support for MacBookAir 6,1 as that now works fine here.

Test Plan

Tested on MacbookAir 6,1 and MacbookAir 6,2

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

adrian created this revision.Feb 2 2023, 11:29 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 2 2023, 11:29 PM
adrian requested review of this revision.Feb 2 2023, 11:29 PM
adrian added a reviewer: markj.
adrian edited the summary of this revision. (Show Details)Feb 2 2023, 11:37 PM
adrian added inline comments.Feb 3 2023, 6:12 AM
sys/dev/asmc/asmcvar.h
73 ↗(On Diff #116376)

hm, don't need these in this commit, i'll delete em before landing

markj added inline comments.Feb 3 2023, 2:41 PM
sys/dev/asmc/asmc.c
160

Extra newline.

1559

10 byte?

1564

v should probably be unsigned?

1576

This can just be v = be32dec(&buf[6]);.

emaste added a subscriber: emaste.Feb 6 2023, 5:26 PM
adrian updated this revision to Diff 116667.Feb 7 2023, 1:11 AM

corrections!

adrian updated this revision to Diff 116669.Feb 7 2023, 1:13 AM

oops

adrian added a comment.Feb 7 2023, 1:13 AM

ok, try this one!

adrian marked 4 inline comments as done.Feb 7 2023, 6:56 AM
markj accepted this revision.Feb 7 2023, 6:20 PM

Seems ok to me.

This revision is now accepted and ready to land.Feb 7 2023, 6:20 PM
Closed by commit rG2e9d05fd6848: asmc: Add support for 10 byte light sensor payloads; MacBookAir6,1 (authored by adrian). · Explain WhyFeb 8 2023, 4:09 AM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rG2e9d05fd6848: asmc: Add support for 10 byte light sensor payloads; MacBookAir6,1.

Revision Contents
Changeset List

PathSize
sys/
dev/
asmc/
46 lines

Diff 116669

View Options

sys/dev/asmc/asmc.c

Loading...