ifnet/API: Move the IfAPI from if_var.h to if.h
ClosedPublic
Actions

Authored by jhibbits on Jan 12 2023, 2:32 AM.

Details

Reviewers

glebius
melifaro

Group Reviewers

network

Commits

rGfe33e0ab83d1: ifnet/API: Move the IfAPI from if_var.h to if.h

Summary

The "public" KPI for ifnet belongs in net/if.h, with net/if_var.h being
implementation details for the netstack. This is the next step in
enforcing that separation.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhibbits created this revision.Jan 12 2023, 2:32 AM

Herald added subscribers: ae, imp. · View Herald TranscriptJan 12 2023, 2:32 AM

jhibbits requested review of this revision.Jan 12 2023, 2:32 AM

Harbormaster completed remote builds in B49070: Diff 114986.Jan 12 2023, 2:32 AM

melifaro accepted this revision.Jan 12 2023, 1:23 PM

melifaro added inline comments.

sys/net/if.h
658	Shouldn't these be under `_KERNEL` as well?

This revision is now accepted and ready to land.Jan 12 2023, 1:23 PM

jhibbits added inline comments.Jan 12 2023, 4:19 PM

sys/net/if.h
658	The netlink test-includes fails if it is.

Closed by commit rGfe33e0ab83d1: ifnet/API: Move the IfAPI from if_var.h to if.h (authored by jhibbits). · Explain WhyJan 12 2023, 4:21 PM

This revision was automatically updated to reflect the committed changes.

jhibbits added a commit: rGfe33e0ab83d1: ifnet/API: Move the IfAPI from if_var.h to if.h.

jhibbits added a reverting change: rGae3301084da1: Revert "ifnet/API: Move the IfAPI from if_var.h to if.h".Jan 13 2023, 2:33 AM

Revision Contents
Changeset List

Path

Size

sys/

net/

if.h

157 lines

if_var.h

145 lines

Diff 114999

View Options

sys/net/if.h