kboot: Add ZFS support to hostdisk
ClosedPublic
Actions

Authored by imp on Jan 10 2023, 12:19 AM.

Details

Reviewers

kevans
manu
allanjude

Commits

rG85ab3bb9897c: kboot: Add ZFS support to hostdisk
rGcc82c650a72f: kboot: Add ZFS support to hostdisk

Summary

Add helper function to walk through the disk drives we've found to look
for zpools. main.c will still need to call this because the loader
hasn't implemented a good way to 'taste' drives for zpools and/or GELI
partitions (mostly because there's no generic list of candidate
devices).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 49035
Build 45924: arc lint + arc unit

Event Timeline

imp created this revision.Jan 10 2023, 12:19 AM

Herald added a reviewer: manu. · View Herald TranscriptJan 10 2023, 12:19 AM

Herald added a subscriber: dab. · View Herald Transcript

imp requested review of this revision.Jan 10 2023, 12:19 AM

Harbormaster completed remote builds in B49035: Diff 114916.Jan 10 2023, 12:19 AM

imp added a child revision: D38008: kboot: Add support for ZFS volumes.Jan 10 2023, 12:19 AM

imp added a parent revision: D38013: kboot: Rework hostdisk.c to allow easier ZFS support..Jan 10 2023, 12:21 AM

imp added inline comments.Jan 10 2023, 12:46 AM

stand/kboot/hostdisk.c
479	... or at least somewhere in common since it needs sanity_check_currdev and It's not clear to me that belongs in libsa instead of common, which means probe_zfs_currdev shouldn't be in libsa since it would then depend on something defined in common...
510	I moved this here to make sure that we only setup this stuff if we're successful. It's not clear the error handling is quite right here though. But init_zfs_boot_options also has some error handling issues if it bails out in the middle: It will leave a number of env vars set improperly (imho).