arm_smcc_1_2_*: Don't trash SP and X19 if no return value structure.
ClosedPublic
Actions

Authored by jhb on Jan 1 2023, 4:03 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Feb 17, 1:14 PM

	Unknown Object (File)
	Sun, Feb 8, 11:06 AM

	Unknown Object (File)
	Sat, Feb 7, 5:21 PM

	Unknown Object (File)
	Sat, Jan 31, 7:46 AM

	Unknown Object (File)
	Dec 7 2025, 11:14 AM

	Unknown Object (File)
	Nov 27 2025, 3:13 AM

	Unknown Object (File)
	Nov 26 2025, 11:10 PM

	Unknown Object (File)
	Nov 25 2025, 2:08 AM

View All Files

Subscribers

emaste

imp

schakrabarti_microsoft.com

Details

Reviewers

whu
andrew
jrtc27

Commits

rG6cc52efa13ed: arm_smcc_1_2_*: Don't trash SP and X19 if no return value structure.

Summary

Jumping direct to ret was not restoring the saved value of x19 and was
also not adjusting sp to discard the two saved registers.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 48928
Build 45817: arc lint + arc unit

Event Timeline

jhb created this revision.Jan 1 2023, 4:03 AM

Herald added subscribers: emaste, imp. · View Herald TranscriptJan 1 2023, 4:03 AM

jhb requested review of this revision.Jan 1 2023, 4:03 AM

Harbormaster completed remote builds in B48928: Diff 114691.Jan 1 2023, 4:03 AM

lwhsu added a subscriber: schakrabarti_microsoft.com.Jan 1 2023, 5:37 AM

andrew accepted this revision.Jan 30 2023, 3:13 PM

This revision is now accepted and ready to land.Jan 30 2023, 3:13 PM

Closed by commit rG6cc52efa13ed: arm_smcc_1_2_*: Don't trash SP and X19 if no return value structure. (authored by jhb). · Explain WhyFeb 1 2023, 9:54 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG6cc52efa13ed: arm_smcc_1_2_*: Don't trash SP and X19 if no return value structure..

Revision Contents
Changeset List

Path

Size

sys/

dev/

psci/

smccc_arm64.S

4 lines

Diff 114691

View Options

sys/dev/psci/smccc_arm64.S

arm_smcc_1_2_*: Don't trash SP and X19 if no return value structure.ClosedPublicActions