MFC after: 2 weeks
Details
Details
manual testing
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 48884 Build 45773: arc lint + arc unit
Event Timeline
| sys/dev/wg/if_wg.c | ||
|---|---|---|
| 2925 | What's the practical difference between if_clone_simple and ifc_attach_cloner that's changing something here? I note that I don't seem to have any problems creating a wg interface in a vnet jail, so I'm not sure I actually understand the problem. | |
| sys/dev/wg/if_wg.c | ||
|---|---|---|
| 2925 | I think this is a follow-up of https://reviews.freebsd.org/D36636 , and should be re-titled . | |
| sys/dev/wg/if_wg.c | ||
|---|---|---|
| 2925 | Yes, this is just moving to the "newer" clone API it seems, but no functional change. The title of the review should be updated to reflect that. | |
| sys/dev/wg/if_wg.c | ||
|---|---|---|
| 2925 | When I tried to create a wg interface in a jail, it failed, and dtrace indicated that the failure was in ifc_create_ifp . This patch fixed it. Or at least, this patch "fixed" it. But it's possible that that failure was due to a different reason. Perhaps because my build was a few weeks old, or perhaps I ran into https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=264981 . I'll retest again without this patch, probably next weekend. | |
Comment Actions
@jhb @kevans you're right, this change isn't necessary to do what I said. I think I got confused by two other problems:
- The jail can't load the if_wg kernel module, and
- https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=264981
Is there any value to this change anyway, as an act of maintenance? Or should I just abandon it?
Comment Actions
Ahh!
If we're switching other stuff away from the if_clone_{simple,advanced} KPI anyways, I don't really see any reason not to proceed (modulo commit message, of course).