if_ovpn: cleanup offsetof() use
ClosedPublic
Actions

Authored by kp on Dec 5 2022, 4:31 PM.

Tags

None

Referenced Files

	F94405315: D37607.diff
	Tue, Sep 17, 4:58 AM

	Unknown Object (File)
	Sat, Sep 14, 2:16 AM

	Unknown Object (File)
	Thu, Sep 12, 12:12 AM

	Unknown Object (File)
	Sun, Sep 8, 9:45 AM

	Unknown Object (File)
	Wed, Sep 4, 5:40 AM

	Unknown Object (File)
	Tue, Aug 27, 12:17 PM

	Unknown Object (File)
	Tue, Aug 27, 12:17 PM

	Unknown Object (File)
	Tue, Aug 27, 12:13 PM

Subscribers

Details

Reviewers

zlei

Group Reviewers

network
pfsense

Commits

rGa002c839ec71: if_ovpn: cleanup offsetof() use

Summary

Move the use of the `offsetof(struct ovpn_counters, fieldname) /
sizeof(uint64_t)` construct into a macro.
This removes a fair bit of code duplication and should make things a
little easier to read.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 48617
Build 45503: arc lint + arc unit

Event Timeline

kp created this revision.Dec 5 2022, 4:31 PM

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptDec 5 2022, 4:31 PM

kp requested review of this revision.Dec 5 2022, 4:31 PM

kp added a parent revision: D37606: if_ovpn: include peer counters in a OVPN_NOTIF_DEL_PEER message.

Harbormaster completed remote builds in B48617: Diff 113840.Dec 5 2022, 4:31 PM

Looks good to me.

This revision is now accepted and ready to land.Dec 6 2022, 8:11 AM

zlei mentioned this in D37606: if_ovpn: include peer counters in a OVPN_NOTIF_DEL_PEER message.Dec 6 2022, 8:14 AM

Closed by commit rGa002c839ec71: if_ovpn: cleanup offsetof() use (authored by kp). · Explain WhyDec 14 2022, 5:51 AM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGa002c839ec71: if_ovpn: cleanup offsetof() use.

Revision Contents
Changeset List

Path

Size

sys/

net/

if_ovpn.c

36 lines

Diff 113840

View Options

if_ovpn: cleanup offsetof() useClosedPublicActions