Page MenuHomeFreeBSD
Differential D37605

if_ovpn: allow peer lookup by vpn4/vpn6 address
ClosedPublic
Actions

Authored by kp on Dec 5 2022, 4:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 4, 10:27 PM
Unknown Object (File)
Wed, Dec 3, 3:54 PM
Unknown Object (File)
Tue, Dec 2, 9:50 AM
Unknown Object (File)
Sun, Nov 30, 1:22 PM
Unknown Object (File)
Thu, Nov 27, 12:43 AM
Unknown Object (File)
Tue, Nov 25, 5:27 PM
Unknown Object (File)
Fri, Nov 21, 8:18 PM
Unknown Object (File)
Nov 8 2025, 4:57 PM
View All Files
Subscribers
ae
glebius
imp
melifaro
zlei

Details

Reviewers
None
Group Reviewers
network
pfsense
Commits
rG92f0cf77db18: if_ovpn: allow peer lookup by vpn4/vpn6 address
Summary

Introduce two more RB_TREEs so that we can look up peers by their peer
id (already present) or vpn4 or vpn6 address.
This removes the last linear scan of the peer list.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 48615
Build 45501: arc lint + arc unit

Event Timeline

kp created this revision.Dec 5 2022, 4:31 PM
Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptDec 5 2022, 4:31 PM
kp requested review of this revision.Dec 5 2022, 4:31 PM
kp added a parent revision: D37604: if_ovpn: implement OVPN_GET_PEER_STATS.
kp added a child revision: D37606: if_ovpn: include peer counters in a OVPN_NOTIF_DEL_PEER message.
Harbormaster completed remote builds in B48615: Diff 113838.Dec 5 2022, 4:31 PM
zlei added a subscriber: zlei.Dec 6 2022, 9:07 AM
zlei added inline comments.
sys/net/if_ovpn.c
299

memcmp might be overweight here.

306

I'd like to use clang / gcc extension __uint128_t to simplify and make the compare performant, but it seems kernel is not ready for it yet ( not available from sys/_stdint.h ).

Maybe just leave as is or convert to two compare of uint64_t .

1688

Compiler is smart :)

1702

Ditto.

kp updated this revision to Diff 113871.Dec 6 2022, 1:08 PM

Assign IP address directly, rather than memcpy()

Harbormaster completed remote builds in B48623: Diff 113871.Dec 6 2022, 1:08 PM
This revision was not accepted when it landed; it landed in state Needs Review.Dec 14 2022, 5:50 AM
Closed by commit rG92f0cf77db18: if_ovpn: allow peer lookup by vpn4/vpn6 address (authored by kp). · Explain Why
This revision was automatically updated to reflect the committed changes.
kp added a commit: rG92f0cf77db18: if_ovpn: allow peer lookup by vpn4/vpn6 address.
kp added a reverting change: rGb079ca8593ed: Revert "if_ovpn: allow peer lookup by vpn4/vpn6 address".Dec 26 2022, 9:40 PM

Revision Contents
Changeset List

PathSize
sys/
net/
81 lines

Diff 113838

View Options

sys/net/if_ovpn.c

Loading...