Always install llvm-objdump as objdump
ClosedPublic
Actions

Authored by emaste on Nov 18 2022, 8:50 PM.

Details

Reviewers

dim
royger

Commits

rG982e61aacc79: Always install llvm-objdump as objdump
rG86edb11e7491: Always install llvm-objdump as objdump

Summary

Instead of providing no /usr/bin/objdump when LLVM_BINUTILS is false.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

exp-run: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=267854

I'm not sure if it's better to install as llvm-objdump (and llvm-objdump.1) and have links, or just avoid the llvm- prefixed versions and install only as objdump.

Is the alias already in OptionalObsoleteFiles.inc ? For the rest, LGTM.

This revision is now accepted and ready to land.Nov 18 2022, 9:05 PM

In D37445#851320, @emaste wrote:

I'm not sure if it's better to install as llvm-objdump (and llvm-objdump.1) and have links, or just avoid the llvm- prefixed versions and install only as objdump.

Since these are hard links (?) it isn't easily visible for an end-user which objdump they are running. Well, unless they try --version or something like that. The only reason for keeping this stuff might be if this is ever backported to a branch which still has the old binutils, but I think it's only stable/12 now, maybe ?

Oh, hm I thought it was duplicated in OptionalObsoleteFiles.inc but I'm mistaken.
There is a section .if ${MK_CLANG} == no && ${MK_LLVM_BINUTILS} == no