ipfw: Spell PFIL_PASS correctly.
ClosedPublic
Actions

Authored by des on Nov 12 2022, 1:22 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Oct 11, 5:51 AM

	Unknown Object (File)
	Sat, Oct 11, 5:50 AM

	Unknown Object (File)
	Sat, Oct 11, 5:50 AM

	Unknown Object (File)
	Fri, Oct 10, 10:39 PM

	Unknown Object (File)
	Tue, Oct 7, 9:53 PM

	Unknown Object (File)
	Thu, Oct 2, 11:26 PM

	Unknown Object (File)
	Mon, Sep 29, 12:34 PM

	Unknown Object (File)
	Sun, Sep 28, 11:08 PM

Subscribers

Details

Reviewers

rscheff

Group Reviewers

Klara

Commits

rG1854fb8fd8ba: ipfw: Spell PFIL_PASS correctly.

Summary

Sponsored by: Netapp
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 48320
Build 45206: arc lint + arc unit

Event Timeline

des created this revision.Nov 12 2022, 1:22 PM

Herald added subscribers: glebius, donner, melifaro and 2 others. · View Herald TranscriptNov 12 2022, 1:22 PM

des requested review of this revision.Nov 12 2022, 1:22 PM

Harbormaster completed remote builds in B48320: Diff 113040.Nov 12 2022, 1:22 PM

Wondering if a stronger type check can be enforced to find all the instances, where a magic number is used for pfil_return_t instead one of the literals...

This revision is now accepted and ready to land.Nov 12 2022, 4:25 PM

Closed by commit rG1854fb8fd8ba: ipfw: Spell PFIL_PASS correctly. (authored by des). · Explain WhyNov 14 2022, 11:20 AM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG1854fb8fd8ba: ipfw: Spell PFIL_PASS correctly..

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

ipfw/

ip_fw_pfil.c

4 lines

Diff 113040

View Options

sys/netpfil/ipfw/ip_fw_pfil.c

ipfw: Spell PFIL_PASS correctly.ClosedPublicActions