Page MenuHomeFreeBSD
Differential D37318

dummynet: fix codel
ClosedPublic
Actions

Authored by kp on Nov 9 2022, 5:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 22, 9:49 PM
Unknown Object (File)
Sat, Jul 18, 5:57 AM
Unknown Object (File)
Sat, Jul 11, 12:32 AM
Unknown Object (File)
Thu, Jul 9, 8:36 PM
Unknown Object (File)
Jul 3 2026, 8:04 AM
Unknown Object (File)
Jul 3 2026, 1:05 AM
Unknown Object (File)
Jul 2 2026, 10:00 PM
Unknown Object (File)
Jun 30 2026, 9:03 PM
View All Files
Subscribers
ae
donner
glebius
imp
melifaro

Details

Reviewers
None
Group Reviewers
network
pfsense
Commits
rG26b9e1f07fa5: dummynet: fix codel
Summary

Serialize rcvif when enqueing packets for codel. We already tried to
restore the serialized rcvif in fq_codel_extract_head(), but that
doesn't work when we fail to serialize it first, so we ended up dropping
all packets passed through codel.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 48246
Build 45132: arc lint + arc unit

Event Timeline

kp created this revision.Nov 9 2022, 5:28 PM
Herald added subscribers: glebius, donner, melifaro and 2 others. · View Herald TranscriptNov 9 2022, 5:28 PM
Harbormaster completed remote builds in B48246: Diff 112814.Nov 9 2022, 5:28 PM
kp requested review of this revision.Nov 9 2022, 5:28 PM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 11 2022, 12:19 PM
Closed by commit rG26b9e1f07fa5: dummynet: fix codel (authored by kp). · Explain Why
This revision was automatically updated to reflect the committed changes.
kp added a commit: rG26b9e1f07fa5: dummynet: fix codel.

Revision Contents
Changeset List

PathSize
sys/
netpfil/
ipfw/
3 lines

Diff 112814

View Options

sys/netpfil/ipfw/dn_sched_fq_codel.c

Loading...