dummynet: fix codel
ClosedPublic
Actions

Authored by kp on Nov 9 2022, 5:28 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Sep 23, 2:03 AM

	Unknown Object (File)
	Thu, Sep 19, 2:10 AM

	Unknown Object (File)
	Wed, Sep 18, 7:21 PM

	Unknown Object (File)
	Wed, Sep 18, 9:38 AM

	Unknown Object (File)
	Sun, Sep 15, 10:13 PM

	Unknown Object (File)
	Tue, Sep 10, 12:01 AM

	Unknown Object (File)
	Sun, Sep 8, 9:59 PM

	Unknown Object (File)
	Sun, Sep 8, 2:02 PM

Subscribers

Details

Reviewers

None

Group Reviewers

network
pfsense

Commits

rG26b9e1f07fa5: dummynet: fix codel

Summary

Serialize rcvif when enqueing packets for codel. We already tried to
restore the serialized rcvif in fq_codel_extract_head(), but that
doesn't work when we fail to serialize it first, so we ended up dropping
all packets passed through codel.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 48246
Build 45132: arc lint + arc unit

Event Timeline

kp created this revision.Nov 9 2022, 5:28 PM

Herald added subscribers: glebius, donner, melifaro and 2 others. · View Herald TranscriptNov 9 2022, 5:28 PM

Harbormaster completed remote builds in B48246: Diff 112814.Nov 9 2022, 5:28 PM

kp requested review of this revision.Nov 9 2022, 5:28 PM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 11 2022, 12:19 PM

Closed by commit rG26b9e1f07fa5: dummynet: fix codel (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG26b9e1f07fa5: dummynet: fix codel.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

ipfw/

dn_sched_fq_codel.c

3 lines

Diff 112814

View Options

sys/netpfil/ipfw/dn_sched_fq_codel.c

dummynet: fix codelClosedPublicActions