linuxkpi: Update `struct irq_work`
ClosedPublic
Actions

Authored by dumbbell on Oct 12 2022, 7:12 PM.

Details

Reviewers

manu

Commits

rG04c127d58d05: linuxkpi: Update `struct irq_work`
rGf021c5c4a177: linuxkpi: Update `struct irq_work`

Summary

The previous llnode field is moved inside another field node.

This node field is a struct __call_single_node in Linux. Here, we
simply add an anonymous struct with the llnode field inside. That
field's new name is llist now.

struct irq_work was changed in an incompatible way. I'm thinking of adding a
#define beside the new structure so that drivers can check it to determine
how to use it, and thus have a single code base working with multiple versions
of FreeBSD. What do you think?

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dumbbell created this revision.Oct 12 2022, 7:12 PM

Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptOct 12 2022, 7:12 PM

dumbbell requested review of this revision.Oct 12 2022, 7:12 PM

Harbormaster completed remote builds in B47803: Diff 111725.Oct 12 2022, 7:12 PM

dumbbell mentioned this in D36869: This patch contains [[ https://github.com/dumbbell/freebsd-src/tree/linuxkpi-changes-for-drm-from-5.11 | a series of commits to linuxkpi ]] in order to support an update of the DRM drivers to match Linux 5.11:.Oct 12 2022, 7:32 PM

struct irq_work was changed in an incompatible way. I'm thinking of adding a #define beside the new structure so that drivers can check it to determine how to use it, and thus have a single code base working with multiple versions of FreeBSD. What do you think?

Anonymous union of struct node and struct llnode?

I think something like this will work. It's not pretty but kills compilation breakage.

union {
	struct llist_node llnode;
	struct {
		struct llist_node llist;
	} node;
};

Good idea @wulf and @hselasky! I just updated the patch.

manu accepted this revision.Nov 5 2022, 5:20 PM

This revision is now accepted and ready to land.Nov 5 2022, 5:20 PM

Closed by commit rGf021c5c4a177: linuxkpi: Update `struct irq_work` (authored by dumbbell). · Explain WhyNov 11 2022, 5:58 PM

This revision was automatically updated to reflect the committed changes.

dumbbell added a commit: rGf021c5c4a177: linuxkpi: Update `struct irq_work`.

manu added a commit: rG04c127d58d05: linuxkpi: Update `struct irq_work`.Jan 24 2023, 8:57 AM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

irq_work.h

7 lines

Diff 112653

View Options

sys/compat/linuxkpi/common/include/linux/irq_work.h

linuxkpi: Update `struct irq_work`ClosedPublicActions