Paths

Table of Contentst

Differential D37236

gzip: Add support for decompressing zstd files.
ClosedPublic
Actions

Authored by des on Nov 2 2022, 1:54 PM.

Tags

None

Referenced Files

	F154837717: D37236.id112495.diff
	Wed, Apr 29, 1:53 PM

	F154772032: D37236.id112596.diff
	Wed, Apr 29, 10:13 AM

	F154769832: D37236.id112596.diff
	Wed, Apr 29, 10:07 AM

	F154733224: D37236.id112495.diff
	Wed, Apr 29, 8:19 AM

	F154729704: D37236.id112495.diff
	Wed, Apr 29, 8:10 AM

	F154702654: D37236.id112519.diff
	Wed, Apr 29, 6:30 AM

	F154700764: D37236.id112519.diff
	Wed, Apr 29, 6:26 AM

	Unknown Object (File)
	Sat, Apr 25, 5:25 PM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG127f4dd60bed: gzip: Add support for decompressing zstd files.
rGf9349d427431: gzip: Add support for decompressing zstd files.

Summary

Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 48120
Build 45007: arc lint + arc unit

Event Timeline

des created this revision.Nov 2 2022, 1:54 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 2 2022, 1:54 PM

des requested review of this revision.Nov 2 2022, 1:54 PM

Harbormaster completed remote builds in B48119: Diff 112495.Nov 2 2022, 1:54 PM

Correct SPDX tag.

Harbormaster completed remote builds in B48120: Diff 112496.Nov 2 2022, 1:57 PM

pstef added a subscriber: pstef.Nov 2 2022, 3:23 PM

pstef added inline comments.

usr.bin/gzip/gzip.c
1608	If this comment is here to stay, I suggest turning it to PL/I style.
usr.bin/gzip/unzstd.c
5	Can we drop this?
56	style nitpick: `bytes_in` is not a boolean.

Incorporate feedback

Harbormaster completed remote builds in B48123: Diff 112519.Nov 2 2022, 5:29 PM

des marked 3 inline comments as done.Nov 2 2022, 5:29 PM

des edited reviewers, added: Klara; removed: allanjude, kevans, thj.Nov 2 2022, 5:38 PM

Reviewed by: allanjude

This revision is now accepted and ready to land.Nov 4 2022, 12:48 PM

Closed by commit rGf9349d427431: gzip: Add support for decompressing zstd files. (authored by des). · Explain WhyNov 4 2022, 1:02 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGf9349d427431: gzip: Add support for decompressing zstd files..

des added a commit: rG127f4dd60bed: gzip: Add support for decompressing zstd files..Jan 17 2024, 3:58 PM

Revision Contents
Changeset List

Path

Size

usr.bin/

gzip/

4 lines

Makefile.depend

1 line

4 lines

61 lines

90 lines

Diff 112496

usr.bin/gzip/Makefile

Loading...

usr.bin/gzip/Makefile.depend

Loading...

usr.bin/gzip/gzip.1

Loading...

usr.bin/gzip/gzip.c

Loading...

usr.bin/gzip/unzstd.c

Loading...