wg: Use atomic(9) instead of concurrency-kit atomics.
ClosedPublic
Actions

Authored by jhb on Oct 7 2022, 10:02 PM.

Details

Reviewers

emaste
markj
kevans

Commits

rG0d103671220b: wg: Use atomic(9) instead of concurrency-kit atomics.
rGe32e1a160e01: wg: Use atomic(9) instead of concurrency-kit atomics.

Summary

Kernel sanitizers only support atomic(9) operations.

Reported by: markj

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Oct 7 2022, 10:02 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 7 2022, 10:02 PM

jhb requested review of this revision.Oct 7 2022, 10:02 PM

jhb added a child revision: D36911: wg: Use zfree..

Harbormaster completed remote builds in B47745: Diff 111569.Oct 7 2022, 10:02 PM

jhb added a parent revision: D35991: wg: Remove some atomics for kp pointers..Oct 7 2022, 10:03 PM

jhb mentioned this in D35993: wg_noise: Use atomic(9) for kp_nonce_send/recv..

do you know why we ended up with the ck atomics?

This revision is now accepted and ready to land.Oct 8 2022, 1:51 AM

emaste mentioned this in D36912: wg: Retire now unused support.h..Oct 8 2022, 1:52 AM

In D36910#838317, @emaste wrote:

do you know why we ended up with the ck atomics?

I think it was done that way to match usage of epoch.

markj accepted this revision.Oct 11 2022, 2:35 PM

markj added inline comments.

sys/dev/wg/if_wg.c
991–992	This line is too long.
1011–1012	This one looks too long too.
sys/dev/wg/wg_noise.c
898	Indentation here is wrong.

jhb marked 2 inline comments as done.Oct 14 2022, 11:49 PM

jhb marked an inline comment as done.Oct 14 2022, 11:52 PM

Style fixes and a few more changes from another dropped review.

This revision now requires review to proceed.Oct 15 2022, 12:20 AM

Harbormaster completed remote builds in B47845: Diff 111821.Oct 15 2022, 12:20 AM

emaste accepted this revision.Oct 15 2022, 12:31 AM

This revision is now accepted and ready to land.Oct 15 2022, 12:31 AM

Rebase.

This revision now requires review to proceed.Oct 24 2022, 7:07 PM

Harbormaster completed remote builds in B47977: Diff 112159.Oct 24 2022, 7:08 PM

jhb edited parent revisions, added: D36909: Import the WireGuard driver from zx2c4.com.; removed: D35991: wg: Remove some atomics for kp pointers..Oct 24 2022, 7:11 PM

emaste accepted this revision.Oct 24 2022, 7:18 PM

This revision is now accepted and ready to land.Oct 24 2022, 7:18 PM

kevans accepted this revision.Oct 25 2022, 1:01 AM

Closed by commit rGe32e1a160e01: wg: Use atomic(9) instead of concurrency-kit atomics. (authored by jhb). · Explain WhyOct 28 2022, 8:56 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGe32e1a160e01: wg: Use atomic(9) instead of concurrency-kit atomics..

jhb added a commit: rG0d103671220b: wg: Use atomic(9) instead of concurrency-kit atomics..Nov 11 2022, 10:05 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

wg/

if_wg.c

52 lines

wg_noise.c

76 lines

Diff 112350

View Options

sys/dev/wg/if_wg.c