Paths

Table of Contentst

Differential D36749

LinuxKPI: Add pci_power querying for drm-kmod
ClosedPublic
Actions

Authored by jfree on Sep 27 2022, 2:09 PM.

Tags

Referenced Files

	Unknown Object (File)
	Sat, Nov 2, 10:02 AM

	Unknown Object (File)
	Oct 2 2024, 6:37 AM

	Unknown Object (File)
	Oct 2 2024, 6:33 AM

	Unknown Object (File)
	Oct 2 2024, 6:28 AM

	Unknown Object (File)
	Oct 2 2024, 6:22 AM

	Unknown Object (File)
	Sep 26 2024, 8:54 AM

	Unknown Object (File)
	Sep 26 2024, 12:06 AM

	Unknown Object (File)
	Sep 23 2024, 1:52 PM

View All 48 Files

Subscribers

Details

Reviewers

manu
wulf
• hselasky

Commits

rG5a612b440928: LinuxKPI: Add pci_power querying for drm-kmod
rG4cb3cb2de206: LinuxKPI: Add pci_power querying for drm-kmod

Summary

Adds a few struct members and a function to get i915_runtime_pm_status()
to compile in drm-kmod.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jfree created this revision.Sep 27 2022, 2:09 PM

Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptSep 27 2022, 2:09 PM

jfree requested review of this revision.Sep 27 2022, 2:09 PM

• hselasky added a subscriber: • hselasky.Sep 27 2022, 2:11 PM

• hselasky added inline comments.

sys/compat/linuxkpi/common/include/linux/pci.h
205	This must be declared in a C-file and extern keyword must be used here instead of static!
1585	Any range check on state?

Added bound checking to pci_power_name()
Made pci_power_names array external

• hselasky added inline comments.Sep 27 2022, 3:00 PM

sys/compat/linuxkpi/common/include/linux/pci.h
1590	return (pci_power_names[0]); ???

• hselasky added inline comments.Sep 27 2022, 3:02 PM

sys/compat/linuxkpi/common/include/linux/pci.h
1585	int pstate = state + 1;
1587	Can you do it like this, instead of hardcoding the array size? if (pstate >= 0 && pstate < nitems(pci_power_names))

Various changes to pci_power_name() thanks to @hselasky

manu added inline comments.Sep 27 2022, 4:01 PM

sys/compat/linuxkpi/common/include/linux/device.h
127	If we add some member this change will break MFC, so if we do that could we add some padding members too for the futur ?

bz added a subscriber: bz.Sep 27 2022, 4:41 PM

bz added inline comments.

sys/compat/linuxkpi/common/include/linux/device.h
127	I thought @imp had moved all allocation specifics into .c files so that if it is at the end it shouldn't be a problem or do I misremember incorrectly what https://reviews.freebsd.org/D34768 was trying to solve?

vishwin added a subscriber: vishwin.Sep 29 2022, 11:52 AM

manu added inline comments.Oct 1 2022, 10:56 AM

sys/compat/linuxkpi/common/include/linux/device.h
127	Indeed, we should be ok by moving it at the end of the struct.

Moved struct dev_pm_info power member to bottom of struct device in <linux/device.h>

This revision was not accepted when it landed; it landed in state Needs Review.Oct 6 2022, 8:18 AM

Closed by commit rG4cb3cb2de206: LinuxKPI: Add pci_power querying for drm-kmod (authored by jfree, committed by manu). · Explain Why

This revision was automatically updated to reflect the committed changes.

manu added a commit: rG4cb3cb2de206: LinuxKPI: Add pci_power querying for drm-kmod.

manu added a commit: rG5a612b440928: LinuxKPI: Add pci_power querying for drm-kmod.Nov 29 2022, 10:40 AM

manu added a reverting change: rG50f61166f7b9: Revert "LinuxKPI: Add pci_power querying for drm-kmod".Dec 15 2022, 9:56 AM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

2 lines

14 lines

6 lines

src/

4 lines

Diff 111501

sys/compat/linuxkpi/common/include/linux/device.h

Loading...

sys/compat/linuxkpi/common/include/linux/pci.h

Loading...

sys/compat/linuxkpi/common/include/linux/pm.h

Loading...

sys/compat/linuxkpi/common/src/linux_pci.c

Loading...