rs: Fix various harmless warnings.
ClosedPublic
Actions

Authored by jhb on Sep 29 2022, 10:47 PM.

Details

Reviewers

emaste
markj
brooks

Commits

rG068c9d3de7c9: rs: Fix various harmless warnings.
rGbb31e1bbf2ad: rs: Fix various harmless warnings.

Summary

Add /* FALLTHROUGH */ comments for intentional fall throughs in getargs().

Use COPYRIGHT and SCCSID for id strings to quiet -Wunused-const-variable warnings from GCC.

While here, remove __FBSDID.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Sep 29 2022, 10:47 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 29 2022, 10:47 PM

jhb requested review of this revision.Sep 29 2022, 10:47 PM

Harbormaster completed remote builds in B47644: Diff 111250.Sep 29 2022, 10:47 PM

jhb added a child revision: D36831: rs: Fix a use after free..Sep 29 2022, 10:47 PM

brooks added inline comments.Sep 29 2022, 10:53 PM

usr.bin/rs/rs.c
480–484	Maybe delete or change to #if 0 while here?
491–492	Another `/* FALLTHROUGH */` here?

emaste added inline comments.Sep 30 2022, 2:17 PM

usr.bin/rs/rs.c
34	IMO we could just drop these instead, `rs.c 8.1 (Berkeley) 6/6/93` in particular doesn't convey anything useful.

Review feedback.

Harbormaster completed remote builds in B47705: Diff 111480.Oct 5 2022, 5:29 PM

brooks accepted this revision.Oct 5 2022, 6:02 PM

This revision is now accepted and ready to land.Oct 5 2022, 6:02 PM

Closed by commit rGbb31e1bbf2ad: rs: Fix various harmless warnings. (authored by jhb). · Explain WhyOct 5 2022, 11:48 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGbb31e1bbf2ad: rs: Fix various harmless warnings..

jhb added a commit: rG068c9d3de7c9: rs: Fix various harmless warnings..Nov 11 2022, 6:39 PM

Revision Contents
Changeset List

Path

Size

usr.bin/

rs/

rs.c

27 lines

Diff 111492

View Options

rs: Fix various harmless warnings.ClosedPublicActions