Differential D36835

rs: Test actual output in the tests.
ClosedPublic
Actions

Authored by jhb on Sep 29 2022, 10:48 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, May 2, 12:40 AM

	Unknown Object (File)
	Thu, May 2, 12:40 AM

	Unknown Object (File)
	Thu, May 2, 12:39 AM

	Unknown Object (File)
	Thu, Apr 25, 2:54 PM

	Unknown Object (File)
	Mar 21 2024, 1:19 PM

	Unknown Object (File)
	Feb 14 2024, 5:22 AM

	Unknown Object (File)
	Feb 14 2024, 5:21 AM

	Unknown Object (File)
	Feb 14 2024, 5:12 AM

View All 27 Files

Subscribers

Details

Reviewers

emaste
markj
brooks

Commits

rG7ad9aa0b9366: rs: Test actual output in the tests.

Summary

Previously the tests just verified if command line arguments raised an
error or not, they did not test how command line arguments affected
the output. This adds some sample (if simple) input and output to
each flag test as well as adding a few additional trivial tests.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Sep 29 2022, 10:48 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 29 2022, 10:48 PM

jhb requested review of this revision.Sep 29 2022, 10:48 PM

Harbormaster completed remote builds in B47649: Diff 111255.Sep 29 2022, 10:48 PM

jhb added a parent revision: D36834: rs: Use getopt() and strtol() instead of mannual parsing..Sep 29 2022, 10:48 PM

This change is what was supposed to happen with the generated smoke test. Too bad it's the first case I can think of in about 5 years...

This revision is now accepted and ready to land.Sep 29 2022, 11:31 PM

Closed by commit rG7ad9aa0b9366: rs: Test actual output in the tests. (authored by jhb). · Explain WhyNov 16 2022, 5:21 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG7ad9aa0b9366: rs: Test actual output in the tests..

Revision Contents
Changeset List

Path

Size

usr.bin/

rs/

tests/

150 lines

Diff 113174

usr.bin/rs/tests/rs_test.sh

Loading...