Differential D36821

libiconv VIQR: Fix a use after free.
ClosedPublic
Actions

Authored by jhb on Sep 29 2022, 10:34 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Oct 13, 2:13 PM

	Unknown Object (File)
	Mon, Oct 12, 6:54 AM

	Unknown Object (File)
	Sun, Oct 11, 6:11 PM

	Unknown Object (File)
	Sun, Oct 11, 10:00 AM

	Unknown Object (File)
	Fri, Oct 9, 4:07 PM

	Unknown Object (File)
	Thu, Oct 1, 9:29 PM

	Unknown Object (File)
	Sep 14 2026, 3:20 PM

	Unknown Object (File)
	Sep 9 2026, 6:58 PM

Subscribers

None

Details

Reviewers

emaste
imp

Commits

rG61abd47a09ad: libiconv VIQR: Fix a use after free.
rG8f27c9d14a55: libiconv VIQR: Fix a use after free.

Summary

Use TAILQ_FOREACH_SAFE to walk to list of children mnemonics to free
them instead of TAILQ_FOREACH.

Reported by: GCC 12 -Wuse-after-free

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Sep 29 2022, 10:34 PM

jhb created this revision.

Harbormaster completed remote builds in B47635: Diff 111239.Sep 29 2022, 10:34 PM

jhb added a parent revision: D36820: libedit: Disable -Wuse-after-free for chartype.c..Sep 29 2022, 10:34 PM

jhb added a child revision: D36822: diff: Fix a use after free as well as a memory leak in change()..

emaste accepted this revision.Sep 29 2022, 11:33 PM

This revision is now accepted and ready to land.Sep 29 2022, 11:33 PM

Closed by commit rG8f27c9d14a55: libiconv VIQR: Fix a use after free. (authored by jhb). · Explain WhyOct 3 2022, 11:14 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG8f27c9d14a55: libiconv VIQR: Fix a use after free..

jhb added a commit: rG61abd47a09ad: libiconv VIQR: Fix a use after free..Nov 11 2022, 6:39 PM

Revision Contents
Changeset List

Path

Size

lib/

libiconv_modules/

VIQR/

4 lines

Diff 111392

lib/libiconv_modules/VIQR/citrus_viqr.c

Loading...