tcp: honor rfc1323 sysctl in passive sessions
ClosedPublic
Actions

Authored by rscheff on Oct 4 2022, 2:52 PM.

Details

Reviewers

tuexen
cc

Group Reviewers

transport

Commits

rG265d0f767ca8: tcp: honor rfc1323 sysctl on passive sessions

Summary

On passive sessions, if rfc1323 was set to any non-zero value, whatever the other
side asks for is negotiated for, not what the local setting was set to.

Also, bump the man page date - with was missed when the first commit was applied.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 47688
Build 44575: arc lint + arc unit

Event Timeline

rscheff created this revision.Oct 4 2022, 2:52 PM

Herald added a reviewer: transport. · View Herald TranscriptOct 4 2022, 2:52 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript

rscheff requested review of this revision.Oct 4 2022, 2:52 PM

Harbormaster completed remote builds in B47688: Diff 111427.Oct 4 2022, 2:52 PM

I would have written (a != b) instead instead of !(a == b). But I leave it up to you.

This revision is now accepted and ready to land.Oct 7 2022, 12:17 PM

Closed by commit rG265d0f767ca8: tcp: honor rfc1323 sysctl on passive sessions (authored by rscheff). · Explain WhyOct 7 2022, 2:56 PM

This revision was automatically updated to reflect the committed changes.

rscheff added a commit: rG265d0f767ca8: tcp: honor rfc1323 sysctl on passive sessions.

Revision Contents
Changeset List

Path

Size

share/

man/

man4/

tcp.4

2 lines

sys/

netinet/

tcp_syncache.c

4 lines

Diff 111427

View Options

share/man/man4/tcp.4