Honor the drop_synfin sysctl variable in TIMEWAIT state
ClosedPublic
Actions

Authored by tuexen on Oct 3 2022, 10:35 AM.

Details

Reviewers

glebius
rrs
rscheff

Group Reviewers

transport

Commits

rGe52b662a3b5f: tcp: honor drop_synfin sysctl variable in TIME-WAIT
rGf8b5681094dd: tcp: honor drop_synfin sysctl variable in TIME-WAIT

Summary

When processing an incoming TCP segment in TIME_WAIT state, the drop_synfin sysctl variable is not honored. Fix this.

Test Plan

https://github.com/freebsd-net/tcp-testsuite/blob/master/state-event-engine/rcv-syn-fin-time-wait/README.md

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Oct 3 2022, 10:35 AM

Herald added a reviewer: transport. · View Herald TranscriptOct 3 2022, 10:35 AM

Herald added subscribers: melifaro, imp. · View Herald Transcript

tuexen requested review of this revision.Oct 3 2022, 10:35 AM

rrs accepted this revision.Oct 3 2022, 11:15 AM

This revision is now accepted and ready to land.Oct 3 2022, 11:15 AM

Closed by commit rGf8b5681094dd: tcp: honor drop_synfin sysctl variable in TIME-WAIT (authored by tuexen). · Explain WhyOct 3 2022, 11:38 AM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rGf8b5681094dd: tcp: honor drop_synfin sysctl variable in TIME-WAIT.

tuexen added a commit: rGe52b662a3b5f: tcp: honor drop_synfin sysctl variable in TIME-WAIT.Feb 1 2023, 11:38 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_timewait.c

14 lines

Diff 111346

View Options

sys/netinet/tcp_timewait.c

Honor the drop_synfin sysctl variable in TIMEWAIT stateClosedPublicActions