Page MenuHomeFreeBSD
Differential D36753

ipfilter: Cast uintmax_t values to size_t when adding to a pointer.
ClosedPublic
Actions

Authored by jhb on Sep 27 2022, 5:41 PM.
Tags
None
Referenced Files
F166812562: D36753.id111148.diff
Sun, Aug 16, 8:21 PM
F166811675: D36753.id111095.diff
Sun, Aug 16, 8:16 PM
Unknown Object (File)
Sat, Aug 15, 8:33 PM
Unknown Object (File)
Sat, Aug 15, 7:46 PM
Unknown Object (File)
Fri, Aug 14, 5:21 AM
Unknown Object (File)
Thu, Aug 13, 8:55 PM
Unknown Object (File)
Wed, Aug 12, 2:51 PM
Unknown Object (File)
Tue, Aug 11, 11:15 PM
View All Files
Subscribers
glebius
imp
melifaro

Details

Reviewers
cy
imp
Commits
rG3e9a8070f741: ipfilter: Cast uintmax_t values to size_t when adding to a pointer.
rG9c4f7e82348b: ipfilter: Cast uintmax_t values to size_t when adding to a pointer.
Summary

GCC warns about the mismatched sizes on 32-bit platforms where
uintmax_t is larger in size than a pointer.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Sep 27 2022, 5:41 PM
Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptSep 27 2022, 5:41 PM
jhb requested review of this revision.Sep 27 2022, 5:41 PM
Harbormaster completed remote builds in B47568: Diff 111095.Sep 27 2022, 5:41 PM
cy accepted this revision.Sep 27 2022, 6:09 PM

lgtm

This revision is now accepted and ready to land.Sep 27 2022, 6:09 PM
imp accepted this revision.Sep 27 2022, 6:16 PM

assuming that you know that these can never be truncated, and that truncation won't cause a problem.

jhb added a comment.Sep 27 2022, 6:19 PM
In D36753#834438, @imp wrote:

assuming that you know that these can never be truncated, and that truncation won't cause a problem.

If you have an offset bigger than size_t, you don't have a valid pointer (or you've wrapped around anyway). In practice arg2 are fairly small values that are offsets of fields in structures.

Closed by commit rG9c4f7e82348b: ipfilter: Cast uintmax_t values to size_t when adding to a pointer. (authored by jhb). · Explain WhySep 28 2022, 9:07 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG9c4f7e82348b: ipfilter: Cast uintmax_t values to size_t when adding to a pointer..
jhb added a commit: rG3e9a8070f741: ipfilter: Cast uintmax_t values to size_t when adding to a pointer..Nov 11 2022, 6:37 PM

Revision Contents
Changeset List

PathSize
sys/
netpfil/
ipfilter/
netinet/
8 lines

Diff 111148

View Options

sys/netpfil/ipfilter/netinet/mlfk_ipl.c

Loading...