Page MenuHomeFreeBSD

ipfilter: Cast uintmax_t values to size_t when adding to a pointer.
ClosedPublic

Authored by jhb on Sep 27 2022, 5:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 1, 11:04 PM
Unknown Object (File)
Thu, May 21, 1:05 AM
Unknown Object (File)
Sat, May 16, 12:57 AM
Unknown Object (File)
Sat, May 16, 12:57 AM
Unknown Object (File)
Sat, May 16, 12:56 AM
Unknown Object (File)
Thu, May 14, 9:02 AM
Unknown Object (File)
May 7 2026, 12:36 PM
Unknown Object (File)
May 6 2026, 10:50 PM

Details

Summary

GCC warns about the mismatched sizes on 32-bit platforms where
uintmax_t is larger in size than a pointer.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Sep 27 2022, 5:41 PM
This revision is now accepted and ready to land.Sep 27 2022, 6:09 PM

assuming that you know that these can never be truncated, and that truncation won't cause a problem.

In D36753#834438, @imp wrote:

assuming that you know that these can never be truncated, and that truncation won't cause a problem.

If you have an offset bigger than size_t, you don't have a valid pointer (or you've wrapped around anyway). In practice arg2 are fairly small values that are offsets of fields in structures.