Page MenuHomeFreeBSD

ipfilter: Cast uintmax_t values to size_t when adding to a pointer.
ClosedPublic

Authored by jhb on Sep 27 2022, 5:41 PM.
Tags
None
Referenced Files
F156520065: D36753.id.diff
Thu, May 14, 9:02 AM
Unknown Object (File)
Thu, May 7, 12:36 PM
Unknown Object (File)
Wed, May 6, 10:50 PM
Unknown Object (File)
Sun, May 3, 11:50 AM
Unknown Object (File)
Fri, May 1, 12:55 PM
Unknown Object (File)
Wed, Apr 29, 8:30 AM
Unknown Object (File)
Wed, Apr 29, 8:25 AM
Unknown Object (File)
Mon, Apr 27, 7:44 PM

Details

Summary

GCC warns about the mismatched sizes on 32-bit platforms where
uintmax_t is larger in size than a pointer.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Sep 27 2022, 5:41 PM
This revision is now accepted and ready to land.Sep 27 2022, 6:09 PM

assuming that you know that these can never be truncated, and that truncation won't cause a problem.

In D36753#834438, @imp wrote:

assuming that you know that these can never be truncated, and that truncation won't cause a problem.

If you have an offset bigger than size_t, you don't have a valid pointer (or you've wrapped around anyway). In practice arg2 are fairly small values that are offsets of fields in structures.