Page MenuHomeFreeBSD

ipfilter: Cast uintmax_t values to size_t when adding to a pointer.
ClosedPublic

Authored by jhb on Sep 27 2022, 5:41 PM.
Tags
None
Referenced Files
F93767588: D36753.diff
Thu, Sep 12, 9:27 AM
Unknown Object (File)
Tue, Sep 10, 5:56 AM
Unknown Object (File)
Sat, Sep 7, 3:01 AM
Unknown Object (File)
Sat, Aug 17, 3:07 AM
Unknown Object (File)
Jul 1 2024, 2:08 AM
Unknown Object (File)
Jun 30 2024, 8:59 AM
Unknown Object (File)
Jun 30 2024, 8:00 AM
Unknown Object (File)
Jun 29 2024, 12:17 AM

Details

Summary

GCC warns about the mismatched sizes on 32-bit platforms where
uintmax_t is larger in size than a pointer.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 47568
Build 44455: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Sep 27 2022, 5:41 PM
This revision is now accepted and ready to land.Sep 27 2022, 6:09 PM

assuming that you know that these can never be truncated, and that truncation won't cause a problem.

In D36753#834438, @imp wrote:

assuming that you know that these can never be truncated, and that truncation won't cause a problem.

If you have an offset bigger than size_t, you don't have a valid pointer (or you've wrapped around anyway). In practice arg2 are fairly small values that are offsets of fields in structures.