Differential D36735

libsa/arp.c: Change printf format string
ClosedPublic
Actions

Authored by mig_semihalf.com on Sep 26 2022, 11:02 PM.

Tags

None

Referenced Files

	F125566655: D36735.id111032.diff
	Sat, Aug 9, 8:10 AM

	Unknown Object (File)
	Tue, Aug 5, 3:17 PM

	Unknown Object (File)
	Jul 7 2025, 1:11 PM

	Unknown Object (File)
	Jul 3 2025, 1:35 PM

	Unknown Object (File)
	Jun 26 2025, 5:53 AM

	Unknown Object (File)
	Jun 26 2025, 4:39 AM

	Unknown Object (File)
	Jun 22 2025, 5:46 AM

	Unknown Object (File)
	Jun 22 2025, 4:31 AM

View All 90 Files

Subscribers

Details

Reviewers

mw
kd
wma
imp
manu

Commits

rG285714ea7a21: libsa/arp.c: Change printf format string
rGc66c6da4f081: libsa/arp.c: Change printf format string

Summary

Change printf format string to avoid compilation termination when ARP_DEBUG macro is defined.

Test Plan

In stand/libsa/arp.c after all #include's and #define's add:
#define ARP_DEBUG
temporary directory to hold compilation files:
mkdir -p $HOME/obj
set appropriate environmental variables, e.g. ARCH=arm64, TARGET_ARCH=aarch64, MAKEOBJDIRPREFIX=$HOME/obj.
In stand/libsa:
sudo -E make buildenv
make
compliation ends with error.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 47585
Build 44472: arc lint + arc unit

Event Timeline

mig_semihalf.com created this revision.Sep 26 2022, 11:02 PM

Herald added a reviewer: manu. · View Herald TranscriptSep 26 2022, 11:02 PM

Herald added a subscriber: dab. · View Herald Transcript

mig_semihalf.com requested review of this revision.Sep 26 2022, 11:02 PM

imp accepted this revision.Sep 26 2022, 11:50 PM

This revision is now accepted and ready to land.Sep 26 2022, 11:50 PM

libsa/arp.c: Change printf format string

Previous revision was created with reversed diff. This
update introduces correct diff.

This revision now requires review to proceed.Sep 28 2022, 1:08 PM

Harbormaster completed remote builds in B47585: Diff 111133.Sep 28 2022, 1:08 PM

ah, that suddenly makes more sense.

This revision is now accepted and ready to land.Sep 29 2022, 2:11 AM

Closed by commit rGc66c6da4f081: libsa/arp.c: Change printf format string (authored by mig_semihalf.com, committed by kd). · Explain WhySep 29 2022, 10:59 AM

This revision was automatically updated to reflect the committed changes.

kd added a commit: rGc66c6da4f081: libsa/arp.c: Change printf format string.

imp added a commit: rG285714ea7a21: libsa/arp.c: Change printf format string.Jan 24 2023, 10:18 PM

Revision Contents
Changeset List

Path

Size

stand/

libsa/

2 lines

Diff 111133

stand/libsa/arp.c

Loading...