Page MenuHomeFreeBSD
Differential D36735

libsa/arp.c: Change printf format string
ClosedPublic
Actions

Authored by mig_semihalf.com on Sep 26 2022, 11:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 3, 1:35 PM
Unknown Object (File)
Thu, Jun 26, 5:53 AM
Unknown Object (File)
Thu, Jun 26, 4:39 AM
Unknown Object (File)
Sun, Jun 22, 5:46 AM
Unknown Object (File)
Sun, Jun 22, 4:31 AM
Unknown Object (File)
Sat, Jun 21, 1:48 PM
Unknown Object (File)
Fri, Jun 20, 11:23 PM
Unknown Object (File)
Sat, Jun 14, 8:15 PM
View All 87 Files
Subscribers
dab

Details

Reviewers
mw
kd
wma
imp
manu
Commits
rG285714ea7a21: libsa/arp.c: Change printf format string
rGc66c6da4f081: libsa/arp.c: Change printf format string
Summary

Change printf format string to avoid compilation termination when ARP_DEBUG macro is defined.

Test Plan

In stand/libsa/arp.c after all #include's and #define's add:
#define ARP_DEBUG
temporary directory to hold compilation files:
mkdir -p $HOME/obj
set appropriate environmental variables, e.g. ARCH=arm64, TARGET_ARCH=aarch64, MAKEOBJDIRPREFIX=$HOME/obj.
In stand/libsa:
sudo -E make buildenv
make
compliation ends with error.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 47585
Build 44472: arc lint + arc unit

Event Timeline

mig_semihalf.com created this revision.Sep 26 2022, 11:02 PM
Herald added a reviewer: manu. · View Herald TranscriptSep 26 2022, 11:02 PM
Herald added a subscriber: dab. · View Herald Transcript
mig_semihalf.com requested review of this revision.Sep 26 2022, 11:02 PM
imp accepted this revision.Sep 26 2022, 11:50 PM
This revision is now accepted and ready to land.Sep 26 2022, 11:50 PM
mig_semihalf.com updated this revision to Diff 111133.Sep 28 2022, 1:08 PM

libsa/arp.c: Change printf format string

Previous revision was created with reversed diff. This
update introduces correct diff.

This revision now requires review to proceed.Sep 28 2022, 1:08 PM
Harbormaster completed remote builds in B47585: Diff 111133.Sep 28 2022, 1:08 PM
imp accepted this revision.Sep 29 2022, 2:11 AM

ah, that suddenly makes more sense.

This revision is now accepted and ready to land.Sep 29 2022, 2:11 AM
Closed by commit rGc66c6da4f081: libsa/arp.c: Change printf format string (authored by mig_semihalf.com, committed by kd). · Explain WhySep 29 2022, 10:59 AM
This revision was automatically updated to reflect the committed changes.
kd added a commit: rGc66c6da4f081: libsa/arp.c: Change printf format string.
imp added a commit: rG285714ea7a21: libsa/arp.c: Change printf format string.Jan 24 2023, 10:18 PM

Revision Contents
Changeset List

PathSize
stand/
libsa/
2 lines

Diff 111133

View Options

stand/libsa/arp.c

Loading...