ipfilter: Cast uintmax_t values to size_t when adding to a pointer.
ClosedPublic
Actions

Authored by jhb on Sep 27 2022, 5:41 PM.

Details

Reviewers

cy
imp

Commits

rG3e9a8070f741: ipfilter: Cast uintmax_t values to size_t when adding to a pointer.
rG9c4f7e82348b: ipfilter: Cast uintmax_t values to size_t when adding to a pointer.

Summary

GCC warns about the mismatched sizes on 32-bit platforms where
uintmax_t is larger in size than a pointer.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 47568
Build 44455: arc lint + arc unit

Event Timeline

jhb created this revision.Sep 27 2022, 5:41 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptSep 27 2022, 5:41 PM

jhb requested review of this revision.Sep 27 2022, 5:41 PM

Harbormaster completed remote builds in B47568: Diff 111095.Sep 27 2022, 5:41 PM

lgtm

This revision is now accepted and ready to land.Sep 27 2022, 6:09 PM

assuming that you know that these can never be truncated, and that truncation won't cause a problem.

In D36753#834438, @imp wrote:

assuming that you know that these can never be truncated, and that truncation won't cause a problem.

If you have an offset bigger than size_t, you don't have a valid pointer (or you've wrapped around anyway). In practice arg2 are fairly small values that are offsets of fields in structures.

Closed by commit rG9c4f7e82348b: ipfilter: Cast uintmax_t values to size_t when adding to a pointer. (authored by jhb). · Explain WhySep 28 2022, 9:07 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG9c4f7e82348b: ipfilter: Cast uintmax_t values to size_t when adding to a pointer..

jhb added a commit: rG3e9a8070f741: ipfilter: Cast uintmax_t values to size_t when adding to a pointer..Nov 11 2022, 6:37 PM

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

ipfilter/

netinet/

mlfk_ipl.c

8 lines

Diff 111095

View Options

sys/netpfil/ipfilter/netinet/mlfk_ipl.c

ipfilter: Cast uintmax_t values to size_t when adding to a pointer.ClosedPublicActions