Page MenuHomeFreeBSD
Differential D36689

if_epair: refactor interface creation and enqueue code.
ClosedPublic
Actions

Authored by melifaro on Sep 24 2022, 8:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 3, 11:36 PM
Unknown Object (File)
Sun, May 3, 5:55 PM
Unknown Object (File)
Tue, Apr 28, 12:36 PM
Unknown Object (File)
Thu, Apr 23, 7:53 PM
Unknown Object (File)
Thu, Apr 16, 3:12 PM
Unknown Object (File)
Apr 9 2026, 7:19 AM
Unknown Object (File)
Apr 6 2026, 2:33 PM
Unknown Object (File)
Apr 6 2026, 6:37 AM
View All Files
Subscribers
ae
glebius
imp

Details

Reviewers
kp
Group Reviewers
network
Commits
rG04a32b802ec7: if_epair: refactor interface creation and enqueue code.
Summary
  • Factor out queue selection (epair_select_queue()) and mbuf preparation (epair_prepare_mbuf()) from epair_menq(). It simplifies epair_menq() implementation and reduces the amount of dependencies on the neighbouring epair.
  • Use dedicated epair_set_state() instead of 2-lines copy-paste
  • Factor out unit selection code (epair_handle_unit()) from epair_clone_create(). It simplifies the clone creation logic.
Test Plan
20:23 [0] m@devel1 s kyua test -k /usr/tests/sys/net/Kyuafile
125/126 passed (1 failed)
  1. The failing one is if_lagg_test:witness

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 47517
Build 44404: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sys/
net/
165 lines

Diff 110929

View Options

sys/net/if_epair.c

Loading...