if_igc: Don't start in promiscious mode by default
ClosedPublic
Actions

Authored by hum_semihalf.com on Sep 15 2022, 11:51 AM.

Tags

None

Referenced Files

	F168025426: D36591.id110720.diff
	Wed, Aug 26, 12:01 AM

	F167954660: D36591.id110601.diff
	Tue, Aug 25, 2:57 PM

	F167954598: D36591.diff
	Tue, Aug 25, 2:56 PM

	Unknown Object (File)
	Tue, Aug 25, 10:26 AM

	Unknown Object (File)
	Sun, Aug 23, 4:28 PM

	Unknown Object (File)
	Sat, Aug 22, 6:07 PM

	Unknown Object (File)
	Sat, Aug 22, 5:36 PM

	Unknown Object (File)
	Fri, Aug 21, 11:18 PM

View All Files

Subscribers

imp

Details

Reviewers

grehan
kbowling
mw
wma
kd

Commits

rG7b8bb67135f2: igc: Don't start in promiscious mode by default
rG55760984d56b: igc: Don't start in promiscious mode by default

Summary

The igc driver always sets the promiscious mode in the initialization
routine regardless the options passed from iflib. Fix this by checking
the interface flags and set mode appropriately.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

hum_semihalf.com requested review of this revision.Sep 15 2022, 11:51 AM

hum_semihalf.com created this revision.

grehan accepted this revision.Sep 17 2022, 3:57 AM

This revision is now accepted and ready to land.Sep 17 2022, 3:57 AM

Closed by commit rG55760984d56b: igc: Don't start in promiscious mode by default (authored by hum_semihalf.com, committed by kd). · Explain WhySep 19 2022, 7:28 AM

This revision was automatically updated to reflect the committed changes.

kd added a commit: rG55760984d56b: igc: Don't start in promiscious mode by default.

Herald added a subscriber: imp. · View Herald TranscriptSep 19 2022, 7:28 AM

kd added a commit: rG7b8bb67135f2: igc: Don't start in promiscious mode by default.Sep 26 2022, 8:28 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

igc/

if_igc.c

2 lines

Diff 110720

View Options

if_igc: Don't start in promiscious mode by defaultClosedPublicActions