Remove dead code in the cscope target
ClosedPublic
Actions

Authored by def on Aug 31 2022, 11:29 AM.

Details

Reviewers

imp
jhb
oshogbo

Commits

rGf0d122573451: Remove dead code in the cscope target

Summary

arm64 is the only currently supported architecture that has ${MACHINE_CPUARCH} set to a different value (aarch64) than ${MACHINE} (arm64), as described in arch(7). However, there is no source directory associated with arm64 that has a name set to ${MACHINE_CPUARCH}.

Remove the dead code that adds a directory with a name set to ${MACHINE_CPUARCH} to a list of directories indexed with cscope. This change allows to use the cscope target on arm64.

My branch:
https://github.com/kwitaszczyk/freebsd/tree/cscope-arm64

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 47197
Build 44084: arc lint + arc unit

Event Timeline

def created this revision.Aug 31 2022, 11:29 AM

Herald added a subscriber: imp. · View Herald TranscriptAug 31 2022, 11:29 AM

def requested review of this revision.Aug 31 2022, 11:29 AM

Harbormaster completed remote builds in B47197: Diff 110010.Aug 31 2022, 11:29 AM

def added reviewers: imp, jhb.Aug 31 2022, 11:30 AM

def edited the summary of this revision. (Show Details)Aug 31 2022, 11:34 AM

This revision is now accepted and ready to land.Aug 31 2022, 4:10 PM

def added a reviewer: pjd.Aug 31 2022, 4:39 PM

def edited reviewers, added: oshogbo; removed: pjd.Sep 9 2022, 2:27 PM

Hmm, does cscope fail because the directory name doesn't exist? (I confess to always using ALL_ARCH=yes myself)

In D36402#836213, @jhb wrote:

Hmm, does cscope fail because the directory name doesn't exist? (I confess to always using ALL_ARCH=yes myself)

cscope fails because it looks for the aarch64 directory that doesn't exist.

oshogbo accepted this revision.Nov 10 2022, 10:55 AM

jhb accepted this revision.Nov 10 2022, 5:15 PM

jhb added inline comments.

sys/Makefile
10	FYI, the rest of this file does not use indentation for nested .if's, and in general we do not do that in src Makefiles AFAIK. It also adds a bit of noise to this commit for which the real changes are removing 3 lines.