Differential D36145

stand: Only compile decompression routines
ClosedPublic
Actions

Authored by imp on Aug 11 2022, 11:26 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Jan 12 2024, 3:03 AM

	Unknown Object (File)
	Oct 11 2023, 8:20 PM

	Unknown Object (File)
	Aug 25 2023, 11:59 PM

	Unknown Object (File)
	Jun 24 2023, 3:04 AM

	Unknown Object (File)
	May 2 2023, 8:04 AM

	Unknown Object (File)
	Apr 13 2023, 3:53 PM

	Unknown Object (File)
	Apr 13 2023, 3:49 PM

	Unknown Object (File)
	Apr 13 2023, 5:15 AM

View All 17 Files

Subscribers

Details

Reviewers

manu
mm
tsoome
kevans
delphij

Commits

rG4f0c9b76cf75: stand: Only compile decompression routines

Summary

We don't need the compress rotuines, nor zstd_opt.c. Remove them.
Expand the number of places we omit code for IN_LIBSA (which are FreeBSD
specific). Due to the agressive optimization, though, this doesn't
reduce the size of the loader. It does reduce the number of 'false
positives' for places to omit to reduce the size as well as reducing the
build time slightly.

Sponsored by: Netflix

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 46868
Build 43757: arc lint + arc unit

Event Timeline

imp created this revision.Aug 11 2022, 11:26 PM

Herald added a reviewer: manu. · View Herald TranscriptAug 11 2022, 11:26 PM

Herald added subscribers: dab, delphij. · View Herald Transcript

imp requested review of this revision.Aug 11 2022, 11:26 PM

Harbormaster completed remote builds in B46868: Diff 109205.Aug 11 2022, 11:26 PM

Note: the changes to openzfs only slightly expand the changes from upstream (which also doesn't have the IN_LIBSA ifdefs).

delphij accepted this revision.Aug 12 2022, 6:30 AM

This revision is now accepted and ready to land.Aug 12 2022, 6:30 AM

tsoome accepted this revision.Aug 12 2022, 6:33 AM

Closed by commit rG4f0c9b76cf75: stand: Only compile decompression routines (authored by imp). · Explain WhyAug 13 2022, 3:49 AM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG4f0c9b76cf75: stand: Only compile decompression routines.

Revision Contents
Changeset List

Path

Size

stand/

libsa/

zfs/

8 lines

sys/

contrib/

openzfs/

module/

zstd/

8 lines

Diff 109205

stand/libsa/zfs/Makefile.inc

Loading...

sys/contrib/openzfs/module/zstd/zfs_zstd.c

Loading...