Install working pkgconfig .pc files for compat libraries
ClosedPublic
Actions

Authored by arichardson on Apr 17 2022, 7:22 PM.

Details

Reviewers

emaste
manu
bapt
jrtc27

Commits

rGac175bd33a21: Install working pkgconfig .pc files for compat libraries

Summary

Instead of installing them to /usr/libdata/pkgconfig, we use
/usr/lib<suffix>/pkgconfig. I'm not sure why native ABI libdirs are
installed to /usr/libdata/pkgconfig instead of /usr/lib/pkgconfig, but
I don't think this commit should change that.

Test Plan

grep -rn libdir= ./usr/lib32/pkgconfig/*.pc

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson created this revision.Apr 17 2022, 7:22 PM

Herald added subscribers: imp, bdrewery. · View Herald TranscriptApr 17 2022, 7:22 PM

arichardson requested review of this revision.Apr 17 2022, 7:22 PM

Harbormaster completed remote builds in B45199: Diff 105086.Apr 17 2022, 7:22 PM

A quick glance says "this looks good to me" if that's the feedback you're looking for :)

Use FreeBSD HEAD instead of CheriBSD HEAD as the base

Harbormaster completed remote builds in B45202: Diff 105099.Apr 18 2022, 2:48 PM

In D34939#792003, @imp wrote:

A quick glance says "this looks good to me" if that's the feedback you're looking for :)

Thanks, yes that is what I was looking for before updating the review :)

Ping? Is this ok to commit?

It's a pitty we can't be consistent and have a libdata equivalent for compat libraries, but on the other hand I don't have better proposal that what is proposed here.

If there are no further comments/suggestions, I'll commit this next week (most likely Wednesday)

This revision was not accepted when it landed; it landed in state Needs Review.Aug 11 2022, 10:47 PM

Closed by commit rGac175bd33a21: Install working pkgconfig .pc files for compat libraries (authored by arichardson). · Explain Why

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rGac175bd33a21: Install working pkgconfig .pc files for compat libraries.