Differential D36016

linuxkpi: Add compat_ptr and ptr_to_compat
ClosedPublic
Actions

Authored by manu on Aug 2 2022, 3:30 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, May 26, 8:22 PM

	Unknown Object (File)
	Thu, May 23, 3:28 AM

	Unknown Object (File)
	Thu, May 9, 5:44 AM

	Unknown Object (File)
	Thu, May 9, 5:44 AM

	Unknown Object (File)
	Thu, May 9, 5:43 AM

	Unknown Object (File)
	Thu, May 9, 5:43 AM

	Unknown Object (File)
	Sat, May 4, 1:14 PM

	Unknown Object (File)
	Thu, May 2, 8:50 PM

View All 30 Files

Subscribers

Details

Reviewers

Commits

rGdc42582096f0: linuxkpi: Add compat_ptr and ptr_to_compat
rG37cda2837c00: linuxkpi: Add compat_ptr and ptr_to_compat

Summary

Needed by drm-kmod.

Obtained from: drm-kmod
Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

manu created this revision.Aug 2 2022, 3:30 PM

Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptAug 2 2022, 3:30 PM

manu requested review of this revision.Aug 2 2022, 3:30 PM

Harbormaster completed remote builds in B46718: Diff 108813.Aug 2 2022, 3:30 PM

manu added a child revision: D36017: linuxkpi: errno: Add EHWPOISON.Aug 2 2022, 3:30 PM

bz added a subscriber: bz.Aug 2 2022, 4:25 PM

bz added inline comments.

sys/compat/linuxkpi/common/include/linux/compat.h
62	Not sure about i386. long for pointers is a Linuxism which is often wrong. Can we live with uintptr_t here instead or is Linux always expecting a long?

• hselasky added a subscriber: • hselasky.Aug 4 2022, 1:04 PM

• hselasky added inline comments.

sys/compat/linuxkpi/common/include/linux/compat.h
62	Yes, you can use uintptr_t here. long is good for i386 too. Only not for cheri.

Switch to uintptr_t

Harbormaster completed remote builds in B46755: Diff 108903.Aug 5 2022, 7:48 AM

bz accepted this revision.Aug 5 2022, 10:26 AM

This revision is now accepted and ready to land.Aug 5 2022, 10:26 AM

Closed by commit rG37cda2837c00: linuxkpi: Add compat_ptr and ptr_to_compat (authored by manu). · Explain WhyAug 8 2022, 2:06 PM

This revision was automatically updated to reflect the committed changes.

manu added a commit: rG37cda2837c00: linuxkpi: Add compat_ptr and ptr_to_compat.

manu added a commit: rGdc42582096f0: linuxkpi: Add compat_ptr and ptr_to_compat.Sep 7 2022, 3:12 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

3 lines

Diff 108994

sys/compat/linuxkpi/common/include/linux/compat.h

Loading...