Page MenuHomeFreeBSD

linuxkpi: Add compat_ptr and ptr_to_compat
ClosedPublic

Authored by manu on Tue, Aug 2, 3:30 PM.

Details

Summary

Needed by drm-kmod.

Obtained from: drm-kmod
Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

manu requested review of this revision.Tue, Aug 2, 3:30 PM
bz added inline comments.
sys/compat/linuxkpi/common/include/linux/compat.h
61

Not sure about i386. long for pointers is a Linuxism which is often wrong. Can we live with uintptr_t here instead or is Linux always expecting a long?

hselasky added inline comments.
sys/compat/linuxkpi/common/include/linux/compat.h
61

Yes, you can use uintptr_t here. long is good for i386 too. Only not for cheri.

This revision is now accepted and ready to land.Fri, Aug 5, 10:26 AM
This revision was automatically updated to reflect the committed changes.