Differential D36016

linuxkpi: Add compat_ptr and ptr_to_compat
ClosedPublic
Actions

Authored by manu on Tue, Aug 2, 3:30 PM.

Details

Reviewers

Commits

rG37cda2837c00: linuxkpi: Add compat_ptr and ptr_to_compat

Summary

Needed by drm-kmod.

Obtained from: drm-kmod
Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository

rG FreeBSD src repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

manu created this revision.Tue, Aug 2, 3:30 PM

Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptTue, Aug 2, 3:30 PM

manu requested review of this revision.Tue, Aug 2, 3:30 PM

Harbormaster completed remote builds in B46718: Diff 108813.Tue, Aug 2, 3:30 PM

manu added a child revision: D36017: linuxkpi: errno: Add EHWPOISON.Tue, Aug 2, 3:30 PM

bz added a subscriber: bz.Tue, Aug 2, 4:25 PM

bz added inline comments.

sys/compat/linuxkpi/common/include/linux/compat.h
61	Not sure about i386. long for pointers is a Linuxism which is often wrong. Can we live with uintptr_t here instead or is Linux always expecting a long?

hselasky added a subscriber: hselasky.Thu, Aug 4, 1:04 PM

hselasky added inline comments.

sys/compat/linuxkpi/common/include/linux/compat.h
61	Yes, you can use uintptr_t here. long is good for i386 too. Only not for cheri.

Switch to uintptr_t

Harbormaster completed remote builds in B46755: Diff 108903.Fri, Aug 5, 7:48 AM

bz accepted this revision.Fri, Aug 5, 10:26 AM

This revision is now accepted and ready to land.Fri, Aug 5, 10:26 AM

Closed by commit rG37cda2837c00: linuxkpi: Add compat_ptr and ptr_to_compat (authored by manu). · Explain WhyMon, Aug 8, 2:06 PM

This revision was automatically updated to reflect the committed changes.

manu added a commit: rG37cda2837c00: linuxkpi: Add compat_ptr and ptr_to_compat.

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

3 lines

Diff 108994

sys/compat/linuxkpi/common/include/linux/compat.h

Loading...