Page MenuHomeFreeBSD
Differential D36016

linuxkpi: Add compat_ptr and ptr_to_compat
ClosedPublic
Actions

Authored by manu on Aug 2 2022, 3:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 8, 4:58 PM
Unknown Object (File)
Sat, Sep 5, 9:52 PM
Unknown Object (File)
Sat, Sep 5, 5:02 PM
Unknown Object (File)
Fri, Sep 4, 7:46 PM
Unknown Object (File)
Thu, Sep 3, 3:21 PM
Unknown Object (File)
Thu, Sep 3, 3:09 PM
Unknown Object (File)
Wed, Sep 2, 10:05 PM
Unknown Object (File)
Tue, Sep 1, 12:53 PM
View All Files
Subscribers
bz
emaste
• hselasky
imp
linuxkpi

Details

Reviewers
bz
Commits
rGdc42582096f0: linuxkpi: Add compat_ptr and ptr_to_compat
rG37cda2837c00: linuxkpi: Add compat_ptr and ptr_to_compat
Summary

Needed by drm-kmod.

Obtained from: drm-kmod
Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 46755
Build 43644: arc lint + arc unit

Event Timeline

manu created this revision.Aug 2 2022, 3:30 PM
Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptAug 2 2022, 3:30 PM
manu requested review of this revision.Aug 2 2022, 3:30 PM
Harbormaster completed remote builds in B46718: Diff 108813.Aug 2 2022, 3:30 PM
manu added a child revision: D36017: linuxkpi: errno: Add EHWPOISON.Aug 2 2022, 3:30 PM
bz added a subscriber: bz.Aug 2 2022, 4:25 PM
bz added inline comments.
sys/compat/linuxkpi/common/include/linux/compat.h
62

Not sure about i386. long for pointers is a Linuxism which is often wrong. Can we live with uintptr_t here instead or is Linux always expecting a long?

• hselasky added a subscriber: • hselasky.Aug 4 2022, 1:04 PM
• hselasky added inline comments.
sys/compat/linuxkpi/common/include/linux/compat.h
62

Yes, you can use uintptr_t here. long is good for i386 too. Only not for cheri.

manu updated this revision to Diff 108903.Aug 5 2022, 7:48 AM

Switch to uintptr_t

Harbormaster completed remote builds in B46755: Diff 108903.Aug 5 2022, 7:48 AM
bz accepted this revision.Aug 5 2022, 10:26 AM
This revision is now accepted and ready to land.Aug 5 2022, 10:26 AM
Closed by commit rG37cda2837c00: linuxkpi: Add compat_ptr and ptr_to_compat (authored by manu). · Explain WhyAug 8 2022, 2:06 PM
This revision was automatically updated to reflect the committed changes.
manu added a commit: rG37cda2837c00: linuxkpi: Add compat_ptr and ptr_to_compat.
manu added a commit: rGdc42582096f0: linuxkpi: Add compat_ptr and ptr_to_compat.Sep 7 2022, 3:12 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
3 lines

Diff 108903

View Options

sys/compat/linuxkpi/common/include/linux/compat.h

Loading...