vm_pager: Remove references to KVME_TYPE_DEFAULT in the kernel
ClosedPublic
Actions

Authored by markj on Jul 12 2022, 4:23 PM.

Details

Reviewers

dougm
alc
kib
imp

Commits

rG7f3c78fbc9b4: vm_pager: Remove references to KVME_TYPE_DEFAULT in the kernel

Summary

Keep the definition around since it's used by userspace.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 46393
Build 43282: arc lint + arc unit

Event Timeline

markj created this revision.Jul 12 2022, 4:23 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 12 2022, 4:23 PM

markj requested review of this revision.Jul 12 2022, 4:23 PM

Harbormaster completed remote builds in B46388: Diff 108063.Jul 12 2022, 4:23 PM

markj added a parent revision: D35790: vm_pager: Remove the default pager.Jul 12 2022, 4:23 PM

Question to consider: What are the implications of userspace using it? Hopefully it's just dead code that never gets executed because KVME_TYPE_DEFAULT is never returned to userspace now...

This revision is now accepted and ready to land.Jul 12 2022, 4:58 PM

kib accepted this revision.Jul 12 2022, 5:01 PM

kib added inline comments.

sys/sys/user.h
490	May be '/* no longer returned */' ?

In D35791#812216, @imp wrote:

Question to consider: What are the implications of userspace using it? Hopefully it's just dead code that never gets executed because KVME_TYPE_DEFAULT is never returned to userspace now...

Yeah, I expect it'll just be dead code. For instance, procstat -v simply won't print "df" anymore. At some point those references should be cleaned up too.

alc accepted this revision.Jul 12 2022, 11:23 PM

alc added inline comments.