Page MenuHomeFreeBSD
Differential D35751

wtap(4): Rename physical interface
ClosedPublic
Actions

Authored by enweiwu on Jul 8 2022, 5:07 AM.
Tags
Referenced Files
F82101537: D35751.diff
Thu, Apr 25, 1:15 PM
Unknown Object (File)
Mon, Apr 22, 7:53 AM
Unknown Object (File)
Thu, Apr 18, 9:29 PM
Unknown Object (File)
Fri, Mar 29, 8:43 PM
Unknown Object (File)
Feb 2 2024, 6:09 AM
Unknown Object (File)
Feb 2 2024, 6:09 AM
Unknown Object (File)
Feb 2 2024, 6:09 AM
Unknown Object (File)
Feb 2 2024, 6:09 AM
View All 51 Files
Subscribers
adrian
imp
wireless

Details

Reviewers
lwhsu
bz
adrian
Commits
rGf7f4ce2d2810: wtap(4): Rename interface name
Summary

Planned commit message:

wtap(4): Rename physical interface

The original physical interface created by wtap is "wlan%d", which will confuse us with the vap created by ifconfig which also named "wlan%d". Rename the physical interface to "wtap%d".

This diff depends on D35624.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

enweiwu requested review of this revision.Jul 8 2022, 5:07 AM
enweiwu created this revision.
enweiwu edited the summary of this revision. (Show Details)
enweiwu added a parent revision: D35624: wtap: remove unused variable and bzero.
adrian added a subscriber: adrian.Jul 8 2022, 5:21 AM

why? it's designed to be used as an emulator / virtual 802.11 interface for building tests. :-) So it should be wlanX.

lwhsu added a comment.Jul 8 2022, 6:42 AM
In D35751#811027, @adrian wrote:

why? it's designed to be used as an emulator / virtual 802.11 interface for building tests. :-) So it should be wlanX.

But we still need to create a wlan interface to use it so the full commands are like:

./wtap c 0
ifconfig wlan0 create wlandev wlan0 wlanmode mesh

Then we have a wlan0 with parent wlan0, looks a bit odd to me. That's why I suggest to do this change. But this could be my misunderstanding, if so, sorry for the noise.

enweiwu added a child revision: D35752: wtap(4): Fix bug in wtap_node_write() and wtap_vap_create().Jul 8 2022, 6:46 AM
enweiwu retitled this revision from Rename physical interface to [wtap] Rename physical interface.Jul 8 2022, 6:54 AM
lwhsu requested changes to this revision.Jul 8 2022, 8:44 AM
lwhsu added inline comments.
sys/dev/wtap/wtap_hal/hal.c
186

I think this is the only part you want to submit, others are already committed in cf337fcd7413486d6c7fc0529d76fefb63597d0e. Please rebase your patch onto the latest main branch.

This revision now requires changes to proceed.Jul 8 2022, 8:44 AM
enweiwu updated this revision to Diff 107910.Jul 8 2022, 10:03 AM
enweiwu retitled this revision from [wtap] Rename physical interface to wtap(4): Rename physical interface.
enweiwu edited the summary of this revision. (Show Details)
adrian accepted this revision.Jul 8 2022, 3:42 PM

oh! hm!

I wonder if this is how it used to be in the deep, distant past. ok, this is right!

enweiwu edited the summary of this revision. (Show Details)Jul 8 2022, 3:47 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 8 2022, 5:45 PM
Closed by commit rGf7f4ce2d2810: wtap(4): Rename interface name (authored by En-Wei Wu <enweiwu@FreeBSD.org>, committed by lwhsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
lwhsu added a commit: rGf7f4ce2d2810: wtap(4): Rename interface name.
bz added a comment.Jul 9 2022, 9:22 PM
In D35751#811179, @adrian wrote:

oh! hm!

I wonder if this is how it used to be in the deep, distant past. ok, this is right!

Even in a deep distant past, this wasn't right; someone just knew what they were doing. Sadly there isn't much/any documentation from that time when the code was committed, is there?

Revision Contents
Changeset List

PathSize
sys/
dev/
wtap/
wtap_hal/
2 lines

Diff 107910

View Options

sys/dev/wtap/wtap_hal/hal.c

Loading...