if_dwc: avoid duplicate packet counts
ClosedPublic
Actions

Authored by mhorne on Jun 15 2022, 7:50 PM.

Details

Reviewers

manu
br
mmel

Commits

rGc7c8b80659f5: if_dwc: avoid duplicate packet counts
rG3a72965a25f9: if_dwc: avoid duplicate packet counts
rG9718759043ec: if_dwc: avoid duplicate packet counts

Summary

We already increment the unicast IPACKETS and OPACKETS counters in the
rx/tx paths, respectively. Multicast packets are counted in the generic
ethernet code. Therefore, we shouldn't increment these counters in
dwc_harvest_stats().

Drop the early return from dwc_rxfinish_one() so that we still count
received packets with e.g. a checksum error.

PR: 263817
Reported by: Jiahao LI <jiahali@blackberry.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.Jun 15 2022, 7:50 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 15 2022, 7:50 PM

mhorne requested review of this revision.Jun 15 2022, 7:50 PM

mhorne added a parent revision: D35498: if_dwc: enable RX checksum offload feature.

Harbormaster completed remote builds in B45997: Diff 106964.Jun 15 2022, 7:50 PM

manu accepted this revision.Jun 15 2022, 8:13 PM

This revision is now accepted and ready to land.Jun 15 2022, 8:13 PM

Closed by commit rG9718759043ec: if_dwc: avoid duplicate packet counts (authored by mhorne). · Explain WhyJun 23 2022, 6:16 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rG9718759043ec: if_dwc: avoid duplicate packet counts.

mhorne added a commit: rG3a72965a25f9: if_dwc: avoid duplicate packet counts.Jul 4 2022, 4:40 PM

mhorne added a commit: rGc7c8b80659f5: if_dwc: avoid duplicate packet counts.Aug 11 2022, 2:54 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

dwc/

if_dwc.c

12 lines

Diff 107315

View Options

if_dwc: avoid duplicate packet countsClosedPublicActions