Page MenuHomeFreeBSD

if_dwc: avoid duplicate packet counts
ClosedPublic

Authored by mhorne on Jun 15 2022, 7:50 PM.
Tags
None
Referenced Files
F142629423: D35499.id.diff
Wed, Jan 21, 3:53 PM
F142615123: D35499.id106964.diff
Wed, Jan 21, 12:53 PM
F142599323: D35499.diff
Wed, Jan 21, 9:55 AM
Unknown Object (File)
Mon, Jan 19, 7:22 PM
Unknown Object (File)
Thu, Jan 15, 2:03 PM
Unknown Object (File)
Mon, Jan 5, 12:39 AM
Unknown Object (File)
Dec 13 2025, 12:56 AM
Unknown Object (File)
Dec 5 2025, 4:59 PM
Subscribers

Details

Summary

We already increment the unicast IPACKETS and OPACKETS counters in the
rx/tx paths, respectively. Multicast packets are counted in the generic
ethernet code. Therefore, we shouldn't increment these counters in
dwc_harvest_stats().

Drop the early return from dwc_rxfinish_one() so that we still count
received packets with e.g. a checksum error.

PR: 263817
Reported by: Jiahao LI <jiahali@blackberry.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable