Page MenuHomeFreeBSD

if_dwc: avoid duplicate packet counts
ClosedPublic

Authored by mhorne on Jun 15 2022, 7:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Aug 18, 8:46 PM
Unknown Object (File)
Tue, Aug 18, 10:08 AM
Unknown Object (File)
Wed, Aug 12, 10:32 PM
Unknown Object (File)
Wed, Aug 12, 9:25 PM
Unknown Object (File)
Mon, Aug 10, 9:23 PM
Unknown Object (File)
Mon, Aug 10, 8:46 AM
Unknown Object (File)
Mon, Aug 10, 3:36 AM
Unknown Object (File)
Sat, Aug 8, 2:23 AM
Subscribers

Details

Summary

We already increment the unicast IPACKETS and OPACKETS counters in the
rx/tx paths, respectively. Multicast packets are counted in the generic
ethernet code. Therefore, we shouldn't increment these counters in
dwc_harvest_stats().

Drop the early return from dwc_rxfinish_one() so that we still count
received packets with e.g. a checksum error.

PR: 263817
Reported by: Jiahao LI <jiahali@blackberry.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable