Page MenuHomeFreeBSD
Differential D35423

tcp: skip sackhole checks on NULL
ClosedPublic
Actions

Authored by rscheff on Jun 7 2022, 6:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 29 2025, 2:08 PM
Unknown Object (File)
Nov 27 2025, 11:37 PM
Unknown Object (File)
Nov 27 2025, 1:01 PM
Unknown Object (File)
Nov 20 2025, 7:53 AM
Unknown Object (File)
Nov 5 2025, 9:10 PM
Unknown Object (File)
Oct 13 2025, 2:09 PM
Unknown Object (File)
Oct 13 2025, 2:08 PM
Unknown Object (File)
Oct 13 2025, 2:08 PM
View All 100 Files
Subscribers
imp
melifaro

Details

Reviewers
tuexen
• hselasky
glebius
Group Reviewers
transport
Commits
rG231e0dd5d1fb: tcp: skip sackhole checks on NULL
Summary

Inadvertedly introduced NULL pointer dereference during
sackhole sanity check in D35387.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45897
Build 42785: arc lint + arc unit

Event Timeline

rscheff created this revision.Jun 7 2022, 6:20 PM
Herald added a reviewer: transport. · View Herald TranscriptJun 7 2022, 6:20 PM
Herald added subscribers: melifaro, imp. · View Herald Transcript
rscheff requested review of this revision.Jun 7 2022, 6:20 PM
Harbormaster completed remote builds in B45897: Diff 106736.Jun 7 2022, 6:20 PM
glebius accepted this revision.Jun 7 2022, 6:27 PM

I think such trivial fixes should be just committed ASAP, not waiting for a review.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 7 2022, 6:47 PM
Closed by commit rG231e0dd5d1fb: tcp: skip sackhole checks on NULL (authored by rscheff). · Explain Why
This revision was automatically updated to reflect the committed changes.
rscheff added a commit: rG231e0dd5d1fb: tcp: skip sackhole checks on NULL.

Revision Contents
Changeset List

PathSize
sys/
netinet/
4 lines

Diff 106736

View Options

sys/netinet/tcp_sack.c

Loading...