Page MenuHomeFreeBSD
Differential D4315

artifical frame should be 3 in arm platform.
ClosedPublic
Actions

Authored by howard0su_gmail.com on Nov 30 2015, 11:50 AM.
Tags
None
Referenced Files
F169820808: D4315.id10662.diff
Wed, Sep 2, 4:21 PM
F169813469: D4315.id10655.diff
Wed, Sep 2, 3:41 PM
F169803925: D4315.id10592.diff
Wed, Sep 2, 3:06 PM
F169791325: D4315.id10771.diff
Wed, Sep 2, 2:11 PM
F169789295: D4315.id10771.diff
Wed, Sep 2, 2:00 PM
F169725948: D4315.diff
Wed, Sep 2, 9:37 AM
Unknown Object (File)
Tue, Sep 1, 11:18 AM
Unknown Object (File)
Mon, Aug 31, 2:12 PM
View All Files
Subscribers
imp

Details

Reviewers
stas
andrew
rwatson
Group Reviewers
Contributor Reviewers (ports)
Commits
rS291855: Allow the artificial profile frames to be adjusted as needed by the user.
Summary

Original value is 10 is incorrect.

Test Plan

dtrace -n 'tick-1s { stack(); }'

check the output

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1383
Build 1388: arc lint + arc unit

Event Timeline

howard0su_gmail.com updated this revision to Diff 10592.Nov 30 2015, 11:50 AM
howard0su_gmail.com retitled this revision from to artifical frame should be 3 in arm platform..
howard0su_gmail.com updated this object.
howard0su_gmail.com edited the test plan for this revision. (Show Details)
Herald added a reviewer: Contributor Reviewers (ports). · View Herald TranscriptNov 30 2015, 11:50 AM
Herald added a subscriber: imp. · View Herald Transcript
howard0su_gmail.com updated this revision to Diff 10655.Dec 1 2015, 11:43 PM
howard0su_gmail.com edited edge metadata.

Add sysctl to tune artifical frame

howard0su_gmail.com added reviewers: rwatson, andrew.Dec 1 2015, 11:46 PM

I think it make sense to make it tuneable.

howard0su_gmail.com updated this revision to Diff 10656.Dec 2 2015, 1:00 AM

Make logic of arframes more explict.

howard0su_gmail.com added a reviewer: stas.Dec 2 2015, 2:55 AM
stas accepted this revision.Dec 2 2015, 3:11 AM
stas edited edge metadata.

Looks good besides the SYSCTL_INT vs UINT issue.

sys/cddl/dev/profile/profile.c
238

SYSCTL_INT?

This revision is now accepted and ready to land.Dec 2 2015, 3:11 AM
howard0su_gmail.com updated this revision to Diff 10662.Dec 2 2015, 3:30 AM
howard0su_gmail.com edited edge metadata.

Address review comments. aframes is INT

This revision now requires review to proceed.Dec 2 2015, 3:30 AM
stas accepted this revision.Dec 2 2015, 3:33 AM
stas edited edge metadata.
This revision is now accepted and ready to land.Dec 2 2015, 3:33 AM
Closed by commit rS291855: Allow the artificial profile frames to be adjusted as needed by the user. (authored by andrew). · Explain WhyDec 5 2015, 10:00 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
cddl/
dev/
profile/
15 lines

Diff 10662

View Options

sys/cddl/dev/profile/profile.c

Loading...