Page MenuHomeFreeBSD
Differential D35299

sockets: enable protocol specific socket buffers
ClosedPublic
Actions

Authored by glebius on May 23 2022, 9:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 12, 2:27 AM
Unknown Object (File)
Mon, Nov 10, 7:59 PM
Unknown Object (File)
Tue, Nov 4, 10:53 PM
Unknown Object (File)
Tue, Nov 4, 8:35 AM
Unknown Object (File)
Oct 13 2025, 9:35 PM
Unknown Object (File)
Oct 7 2025, 12:26 PM
Unknown Object (File)
Sep 23 2025, 6:43 PM
Unknown Object (File)
Sep 20 2025, 2:18 PM
View All Files
Subscribers
imp

Details

Reviewers
markj
Group Reviewers
network
transport
Commits
rGa4fc41423f7d: sockets: enable protocol specific socket buffers
Summary

Split struct sockbuf into common shared fields and protocol specific
union, where protocols are free to implement whatever buffer they
want. Such protocols should mark themselves with PR_SOCKBUF and are
expected to initialize their buffers in their pr_attach and tear
them down in pr_detach.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45745
Build 42633: arc lint + arc unit

Event Timeline

glebius created this revision.May 23 2022, 9:02 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 23 2022, 9:02 PM
glebius requested review of this revision.May 23 2022, 9:02 PM
Harbormaster completed remote builds in B45680: Diff 106298.May 23 2022, 9:02 PM
glebius added a parent revision: D35298: unix: provide an option to return locked from unp_connectat().May 23 2022, 9:02 PM
glebius added a child revision: D35300: unix/dgram: use minimal possible socket buffer for PF_UNIX/SOCK_DGRAM.
glebius added a child revision: D35305: libc/syslog: deprecate use of "/var/run/logpriv".May 23 2022, 9:07 PM
glebius added reviewers: network, markj.May 23 2022, 9:12 PM
glebius added a comment.May 23 2022, 9:25 PM

Note: this patch is a step towards D35303.

markj accepted this revision as: markj.May 24 2022, 3:17 PM
markj added inline comments.
sys/sys/sockbuf.h
106
This revision is now accepted and ready to land.May 24 2022, 3:17 PM
glebius updated this revision to Diff 106424.May 27 2022, 3:28 PM

Rebase over d59bc188d652dfaa06bef9963120aa54c4c68875

This revision now requires review to proceed.May 27 2022, 3:28 PM
Harbormaster completed remote builds in B45745: Diff 106424.May 27 2022, 3:28 PM
glebius added a reviewer: transport.May 28 2022, 3:50 AM
markj accepted this revision as: markj.May 30 2022, 1:45 PM
This revision is now accepted and ready to land.May 30 2022, 1:45 PM
Closed by commit rGa4fc41423f7d: sockets: enable protocol specific socket buffers (authored by glebius). · Explain WhyJun 24 2022, 4:11 PM
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rGa4fc41423f7d: sockets: enable protocol specific socket buffers.

Revision Contents
Changeset List

PathSize
sys/
kern/
12 lines
sys/
3 lines
87 lines

Diff 106424

View Options

sys/kern/uipc_socket.c

Loading...
View Options

sys/sys/protosw.h

Loading...
View Options

sys/sys/sockbuf.h

Loading...